Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws): set DD_SOURCE, DD_SERVICE, and DD_HOST for AWS Batch logs #693

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

williamsbdev
Copy link

What does this PR do?

This PR sets the DD_SOURCE, DD_SERVICE, and DD_HOST values for logs coming from AWS Batch.

Motivation

All of our batch logs are lumped into one bucket. We'd like to be able to separate out our AWS Batch logs by job, using DD_SERVICE while having a simple value of batch for the DD_SOURCE. The DD_HOST is set to the use the Fargate container ID.

Testing Guidelines

Build this and update the forwarder lambda to use the new zip. Ensure that AWS Batch logs come through appropriately.

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

@williamsbdev
Copy link
Author

Checking in on this PR to see what else is needed.

I see @sabiurr and @jvanbrie have been the most recent contributors to new versions. Can you help coach/guide me on how best to submit a PR?

@williamsbdev
Copy link
Author

@joaquinrios - I saw you approved a different PR. Can you help coach/guide me on how best to submit work for review?

@williamsbdev williamsbdev changed the title feat: set DD_SOURCE, DD_SERVICE, and DD_HOST for AWS Batch logs feat(aws): set DD_SOURCE, DD_SERVICE, and DD_HOST for AWS Batch logs Sep 15, 2023
@activehigh
Copy link

activehigh commented Aug 21, 2024

Hey guys, is this PR getting merged soon? We need this feature to include /aws/batch/job logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants