Try to setup taskcat tests

aws/logs_monitoring/template.yaml

@@ -57,7 +57,7 @@
     Description: DO NOT CHANGE unless you know what you are doing. Override the default location of the function source code.
   InstallAsLayer:
     Type: String
-    Default: true
+    Default: "true"
     Description: Whether to use the layer-based installation flow. Set to false to use our legacy installation flow, which installs a second function that copies the forwarder code from Github to an S3 bucket. Defaults to true.
     AllowedValues:
       - true
@@ -72,35 +72,35 @@
     Description: Add custom tags to forwarded logs, comma-delimited string, no trailing comma, e.g., env:prod,stack:classic
   DdFetchLambdaTags:
     Type: String
-    Default: true
+    Default: "true"
     AllowedValues:
       - true
       - false
     Description: Let the forwarder fetch Lambda tags using GetResources API calls and apply them to logs, metrics and traces. If set to true, permission tag:GetResources will be automatically added to the Lambda execution IAM role. The tags are cached in memory and S3 so that they'll only be fetched when the function cold starts or when the TTL (1 hour) expires. The forwarder increments the aws.lambda.enhanced.get_resources_api_calls metric for each API call made.
   DdFetchLogGroupTags:
     Type: String
-    Default: true
+    Default: "true"
     AllowedValues:
       - true
       - false
     Description: Let the forwarder fetch Log Group tags using ListTagsLogGroup and apply them to logs, metrics and traces. If set to true, permission logs:ListTagsLogGroup will be automatically added to the Lambda execution IAM role. The tags are cached in memory and S3 so that they'll only be fetched when the function cold starts or when the TTL (1 hour) expires. The forwarder increments the aws.lambda.enhanced.list_tags_log_group_api_call metric for each API call made.
   DdFetchStepFunctionsTags:
     Type: String
-    Default: true
+    Default: "true"
     AllowedValues:
       - true
       - false
     Description: Let the forwarder fetch Step Functions tags using GetResources API calls and apply them to logs, metrics and traces. If set to true, permission tag:GetResources will be automatically added to the Lambda execution IAM role. The tags are cached in memory and S3 so that they'll only be fetched when the function cold starts or when the TTL (1 hour) expires. The forwarder increments the aws.lambda.enhanced.get_resources_api_calls metric for each API call made.
   DdUseTcp:
     Type: String
-    Default: false
+    Default: "false"
     AllowedValues:
       - true
       - false
     Description: By default, the forwarder sends logs using HTTPS through the port 443. To send logs over an SSL encrypted TCP connection, set this parameter to true.
   DdNoSsl:
     Type: String
-    Default: false
+    Default: "false"
     AllowedValues:
       - true
       - false
@@ -115,21 +115,21 @@
     Description: The endpoint port to forward the logs to, useful for forwarding logs through a proxy
   DdSkipSslValidation:
     Type: String
-    Default: false
+    Default: "false"
     AllowedValues:
       - true
       - false
     Description: Send logs over HTTPS, while NOT validating the certificate provided by the endpoint. This will still encrypt the traffic between the forwarder and the log intake endpoint, but will not verify if the destination SSL certificate is valid.
   RedactIp:
     Type: String
-    Default: false
+    Default: "false"
     AllowedValues:
       - true
       - false
     Description: Replace text matching \d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3} with xxx.xxx.xxx.xxx
   RedactEmail:
     Type: String
-    Default: false
+    Default: "false"
     AllowedValues:
       - true
       - false
@@ -156,35 +156,35 @@
     Description: Use the supplied regular expression to detect for a new log line for multiline logs from S3, e.g., use expression "\d{2}\/\d{2}\/\d{4}" for multiline logs beginning with pattern "11/10/2014".
   DdForwardLog:
     Type: String
-    Default: true
+    Default: "true"
     AllowedValues:
       - true
       - false
     Description: Set to false to disable log forwarding, while continuing to forward other observability data, such as metrics and traces from Lambda functions.
   DdStepFunctionsTraceEnabled:
     Type: String
-    Default: false
+    Default: "false"
     AllowedValues:
       - true
       - false
     Description: Set to true to enable tracing for all Step Functions.
   DdUseCompression:
     Type: String
-    Default: true
+    Default: "true"
     AllowedValues:
       - true
       - false
     Description: Set to false to disable log compression. Only valid when sending logs over HTTP.
   DdUsePrivateLink:
     Type: String
-    Default: false
+    Default: "false"
     AllowedValues:
       - true
       - false
     Description: DEPRECATED, DO NOT CHANGE. See README.md for details. Set to true to deploy the Forwarder to a VPC and send logs, metrics, and traces via AWS PrivateLink. When set to true, must also set VPCSecurityGroupIds and VPCSubnetIds.
   DdUseVPC:
     Type: String
-    Default: false
+    Default: "false"
     AllowedValues:
       - true
       - false
@@ -240,7 +240,7 @@
     Description: (Optional) The name of the S3 bucket to store access logs. Leave empty if access logging is not needed.
   DdStoreFailedEvents:
     Type: String
-    Default: false
+    Default: "false"
     AllowedValues:
       - true
       - false
@@ -583,7 +583,7 @@
                   Condition:
                     StringLike:
                       s3:prefix:
-                        - "retry/*"
+                        - "failed_events/*"
                         - "log-group-cache/*"
                   Effect: Allow
                 - !Ref AWS::NoValue

aws/logs_monitoring/tools/taskcat/.gitignore

@@ -0,0 +1,2 @@
+tmp
+taskcat_outputs

aws/logs_monitoring/tools/taskcat/.taskcat.yml

@@ -0,0 +1,14 @@
+general:
+  auth:
+    default: "<REPLACE_AWS_PROFILE>"
+  s3_bucket: datadog-cloudformation-templates-aws-taskcat-test
+
+project:
+  name: aws-quickstart
+  regions:
+    - us-east-2
+tests:
+  default:
+    template: ./template.yaml
+    parameters:
+      DdApiKey: "<REPLACE_DD_API_KEY>"

aws/logs_monitoring/tools/taskcat/run-taskcat.sh

@@ -0,0 +1,38 @@
+#!/bin/bash
+
+set -ex 
+
+if [ -z "$AWS_SSO_PROFILE_NAME" ]; then
+    echo "Missing AWS_SSO_PROFILE_NAME - Must specify an AWS profile name"
+    exit 1
+fi
+
+# aws sso login --profile ${AWS_SSO_PROFILE_NAME}
+
+TASKCAT_S3_BUCKET="lambdaforwarder-taskcat-test"
+TASKCAT_PROJECT="aws-lambda-forwarder-taskcat-tests"
+#
+#if [ -z "$DD_API_KEY" ]; then
+#    echo "Missing DD_API_KEY - Must specify a Datadog API key"
+#    exit 1
+#fi
+#
+#if [ -z "$DD_APP_KEY" ]; then
+#    echo "Missing DD_APP_KEY - Must specify a Datadog APP key"
+#    exit 1
+#fi
+#
+mkdir -p ./tmp
+
+for f in ../../template.yaml; do
+   sed "s|<BUCKET_PLACEHOLDER>.s3.amazonaws.com/aws/<VERSION_PLACEHOLDER>|${TASKCAT_S3_BUCKET}.s3.amazonaws.com/${TASKCAT_PROJECT}|g" $f > ./tmp/$(basename $f)
+done
+
+sed "s|<REPLACE_DD_API_KEY>|${DD_API_KEY}|g ; s|<REPLACE_DD_APP_KEY>|${DD_APP_KEY}|g ; s|<REPLACE_AWS_PROFILE>|${AWS_SSO_PROFILE_NAME}|g" ./.taskcat.yml > ./tmp/.taskcat.yml
+
+taskcat upload -b ${TASKCAT_S3_BUCKET} -k ${TASKCAT_PROJECT} -p tmp
+
+taskcat test run --skip-upload --project-root tmp --no-delete
+
+echo "To delete test stacks, run:"
+echo " taskcat test clean ${TASKCAT_PROJECT} -a ${AWS_SSO_PROFILE_NAME}"