Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs forwarder] update CFT template to pass cfn-lint #850

Merged
merged 1 commit into from
Sep 19, 2024
Merged

[Logs forwarder] update CFT template to pass cfn-lint #850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,5 @@ jobs:
run: |
pip install cfn-lint==1.11.1
cfn-lint --version
cfn-lint -t aws/logs_monitoring/template.yaml -i W1030
cfn-lint -t aws/logs_monitoring/template.yaml
cfn-lint -t aws/rds_enhanced_monitoring/rds-enhanced-sam-template.yaml
14 changes: 12 additions & 2 deletions aws/logs_monitoring/template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,10 @@ Conditions:
- !Condition CreateS3Bucket
- !Not
- !Equals [!Ref DdForwarderExistingBucketName, ""]
SetVpcSecurityGroupIds: !Not
- !Equals [!Join ["", !Ref VPCSecurityGroupIds], ""]
SetVpcSubnetIds: !Not
- !Equals [!Join ["", !Ref VPCSubnetIds], ""]
Rules:
MustSetDdApiKey:
Assertions:
Expand Down Expand Up @@ -526,8 +530,14 @@ Resources:
- !Ref AWS::NoValue
VpcConfig: !If
- UseVPC
- SecurityGroupIds: !Ref VPCSecurityGroupIds
SubnetIds: !Ref VPCSubnetIds
- SecurityGroupIds: !If
- SetVpcSecurityGroupIds
- !Ref VPCSecurityGroupIds
- !Ref AWS::NoValue
SubnetIds: !If
- SetVpcSubnetIds
- !Ref VPCSubnetIds
- !Ref AWS::NoValue
- !Ref AWS::NoValue
ForwarderRole:
Type: AWS::IAM::Role
Expand Down
Loading