Remove secrets from logs #518
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zippolyte
previously approved these changes
Jan 23, 2020
jirikuncar
force-pushed
the
274-logger
branch
from
dd269ac
to
21224bc
Compare
jirikuncar
force-pushed
the
274-logger
branch
from
21224bc
to
1d97a24
Compare
(closes DataDog#274)
jirikuncar
force-pushed
the
274-logger
branch
from
1d97a24
to
82d37ac
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
zippolyte
approved these changes
Jan 23, 2020
|
This issue has been automatically marked as stale because it has not had activity in the last 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(closes #274)
What does this PR do?
Adds formatters to all loggers that replace ap(pi) keys.
Description of the Change
During client initialisation a new
SecretFormatteris added.Possible Drawbacks
It might slow down logging.
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.