Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python 3.8 classifier #709

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add python 3.8 classifier #709

wants to merge 2 commits into from

Conversation

AyumuKasuga
Copy link

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue, or add one feature, at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Fixed setup.py

Description of the Change

Since there is already py38 in tox.ini -- we can add related classifier to the setup.py file.

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@AyumuKasuga AyumuKasuga requested a review from a team as a code owner December 27, 2021 11:03
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days.
Note that the issue will not be automatically closed, but this notification will remind us to investigate why there's been inactivity.

@github-actions github-actions bot added the stale Stale - Bot reminder label Jan 27, 2022
jirikuncar
jirikuncar previously approved these changes Feb 1, 2022
View reviewed changes
@jirikuncar
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@sgnn7
Copy link
Contributor

sgnn7 commented Feb 2, 2022

@AyumuKasuga If the branch gets a rebase, the unit tests should pass now

@AyumuKasuga
Copy link
Author

Rebased @sgnn7

@sgnn7
Copy link
Contributor

sgnn7 commented Feb 2, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@sgnn7
Copy link
Contributor

sgnn7 commented Feb 2, 2022

@AyumuKasuga LGTM but I'll leave the final review/merge to @jirikuncar

@jirikuncar jirikuncar added the changelog/Added Added features results into a minor version bump label Feb 4, 2022
@jirikuncar jirikuncar changed the title Add python3.8 classifier. Add python3.8 classifier Feb 4, 2022
@jirikuncar jirikuncar changed the title Add python3.8 classifier Add python 3.8 classifier Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jirikuncar jirikuncar jirikuncar left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
changelog/Added Added features results into a minor version bump stale Stale - Bot reminder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AyumuKasuga @jirikuncar @sgnn7