Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stale client_transport tag #802

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Fix stale client_transport tag #802

merged 2 commits into from
Dec 4, 2023

Conversation

vickenty
Copy link
Contributor

What does this PR do?

This patch makes the client_transport tag dynamic and updates it every time the socket_path property is updated.

Description of the Change

datadog.initialize reassigns socket_path property on the global statsd instance, but the client_transport tag was computed in the constructor and never updated, causing client to misreport transport as udp when a unix socket was actually used.

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

initialize reassigns socket_path property on the global statsd
instance, but the client_transport tag was computed in the constructor
and never updated, causing client to misreport transport as udp when a
unix socket was actually used.

This patch makes the tag dynamic and updates it every time the
socket_path property is updated.
@vickenty vickenty marked this pull request as ready for review November 23, 2023 18:02
@vickenty vickenty requested review from a team as code owners November 23, 2023 18:02
@vickenty vickenty changed the title AMLII-1086 fix stale client_transport tag Fix stale client_transport tag Nov 23, 2023
@vickenty vickenty added the changelog/Fixed Fixed features results into a bug fix version bump label Nov 23, 2023
@vickenty vickenty merged commit ff9f020 into master Dec 4, 2023
11 checks passed
@vickenty vickenty deleted the vickenty/transport branch December 4, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/Fixed Fixed features results into a bug fix version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants