Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMLII-2170] fix removed/renamed function flush #868

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

andrewqian2001datadog
Copy link
Contributor

@andrewqian2001datadog andrewqian2001datadog commented Nov 15, 2024

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue, or add one feature, at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Renaming the flush function caused a breaking change

Issue 1, 2

Description of the Change

Add the flush function back to the api and revert renaming of another global variable.

Verification Process

Unit tests.

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@andrewqian2001datadog andrewqian2001datadog self-assigned this Nov 15, 2024
@andrewqian2001datadog andrewqian2001datadog added the kind/bug Bug related issue label Nov 15, 2024
@andrewqian2001datadog andrewqian2001datadog marked this pull request as ready for review November 15, 2024 15:39
@andrewqian2001datadog andrewqian2001datadog added the changelog/Fixed Fixed features results into a bug fix version bump label Nov 15, 2024
@amaskara-dd amaskara-dd merged commit 362e187 into master Nov 15, 2024
14 of 15 checks passed
@amaskara-dd amaskara-dd deleted the fix-missing-flush-function branch November 15, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/Fixed Fixed features results into a bug fix version bump kind/bug Bug related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants