Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some detekt issues #2043

Conversation

mariusc83
Copy link
Collaborator

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@mariusc83 mariusc83 requested review from a team as code owners May 21, 2024 14:25
@mariusc83 mariusc83 self-assigned this May 21, 2024
@mariusc83 mariusc83 force-pushed the mconstantin/fix-detekt-issues branch from 5714f42 to 4f942d6 Compare May 21, 2024 14:47
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.19%. Comparing base (9117094) to head (4f942d6).
Report is 55 commits behind head on nogorodnikov/merge-develop-into-otel-support-170424.

Additional details and impacted files
@@                                   Coverage Diff                                    @@
##           nogorodnikov/merge-develop-into-otel-support-170424    #2043       +/-   ##
========================================================================================
- Coverage                                                83.23%   64.19%   -19.03%     
========================================================================================
  Files                                                      491      759      +268     
  Lines                                                    17685    28314    +10629     
  Branches                                                  2685     4757     +2072     
========================================================================================
+ Hits                                                     14719    18176     +3457     
- Misses                                                    2227     8912     +6685     
- Partials                                                   739     1226      +487     
Files Coverage Δ
...ce/opentelemetry/internal/DatadogContextStorage.kt 66.67% <ø> (ø)
...ndroid/trace/opentelemetry/internal/OtelContext.kt 89.47% <ø> (ø)
.../android/trace/opentelemetry/internal/OtelScope.kt 100.00% <ø> (ø)
.../kotlin/com/datadog/android/trace/AndroidTracer.kt 96.00% <ø> (-0.23%) ⬇️
...atadog/android/trace/internal/FeatureSdkCoreExt.kt 100.00% <ø> (ø)
...dog/android/trace/internal/data/OtelTraceWriter.kt 88.46% <ø> (ø)

... and 131 files with indirect coverage changes

@mariusc83 mariusc83 merged commit ad06c50 into nogorodnikov/merge-develop-into-otel-support-170424 May 21, 2024
22 checks passed
@mariusc83 mariusc83 deleted the mconstantin/fix-detekt-issues branch May 21, 2024 15:43
@xgouchet xgouchet added this to the 2.11.x milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants