Add implementations of benchmark profiling api #2220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/profiling #2220 +/- ##
=====================================================
+ Coverage 69.92% 70.05% +0.12%
=====================================================
Files 726 726
Lines 27007 27009 +2
Branches 4528 4528
=====================================================
+ Hits 18884 18919 +35
+ Misses 6841 6817 -24
+ Partials 1282 1273 -9 |
0xnm
previously approved these changes
Aug 29, 2024
| operationName: String, | ||
| block: BenchmarkSpan.() -> T | ||
| ): T { | ||
| val tracer = GlobalBenchmark.get().getTracer("dd.sdk.android") |
There was a problem hiding this comment.
is it dd.sdk.android and not dd-sdk-android because of the some format requirements?
There was a problem hiding this comment.
No, it's just used as a unique identifier for the open-telemetry tracer, since we only want one tracer for benchmarking, it can be any string here.
But in case of confusion, I change it to "dd-sdk-android".
ambushwork
force-pushed
the
yl/profiling/interface-implementation
branch
from
4406bde
to
2e1399e
Compare
0xnm
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
BenchmarkTracerAPIReview checklist (to be filled by reviewers)