Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-5977 add configuration to set uploadSchedulerStrategy #2224

Conversation

xgouchet
Copy link
Collaborator

What does this PR do?

Let customer chose their UploadSchedulerStrategy

@xgouchet xgouchet requested review from a team as code owners August 30, 2024 11:10
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.95%. Comparing base (87cc448) to head (39d68ca).
Report is 2 commits behind head on develop.

Current head 39d68ca differs from pull request most recent head 128721c

Please upload reports for the commit 128721c to get more accurate results.

Files with missing lines Patch % Lines
...n/com/datadog/android/core/internal/CoreFeature.kt 50.00% 1 Missing ⚠️
...in/com/datadog/android/core/internal/SdkFeature.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2224      +/-   ##
===========================================
- Coverage    70.02%   69.95%   -0.07%     
===========================================
  Files          727      727              
  Lines        27036    27020      -16     
  Branches      4556     4551       -5     
===========================================
- Hits         18931    18901      -30     
- Misses        6828     6842      +14     
  Partials      1277     1277              
Files with missing lines Coverage Δ
...atadog/android/core/configuration/Configuration.kt 97.12% <100.00%> (+0.12%) ⬆️
...n/com/datadog/android/core/internal/CoreFeature.kt 87.16% <50.00%> (-0.22%) ⬇️
...in/com/datadog/android/core/internal/SdkFeature.kt 91.01% <50.00%> (-0.48%) ⬇️

... and 29 files with indirect coverage changes

* @param uploadSchedulerStrategy the upload scheduler strategy,
* or null to use the default strategy (default: null)
*/
fun setUploadScheduledStrategy(uploadSchedulerStrategy: UploadSchedulerStrategy?): Builder {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be called setUploadSchedulerStrategy?

Suggested change
fun setUploadScheduledStrategy(uploadSchedulerStrategy: UploadSchedulerStrategy?): Builder {
fun setUploadSchedulerStrategy(uploadSchedulerStrategy: UploadSchedulerStrategy?): Builder {

@xgouchet xgouchet force-pushed the xgouchet/RUM-5977/configure_custom_upload_scheduler_strategy branch from 39d68ca to aaf2050 Compare September 2, 2024 08:33
@xgouchet xgouchet force-pushed the xgouchet/RUM-5977/configure_custom_upload_scheduler_strategy branch from aaf2050 to 128721c Compare September 3, 2024 08:14
@xgouchet xgouchet merged commit f328e58 into develop Sep 3, 2024
23 checks passed
@xgouchet xgouchet deleted the xgouchet/RUM-5977/configure_custom_upload_scheduler_strategy branch September 3, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants