Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detekt the api coverage in Integration tests #2300

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

xgouchet
Copy link
Collaborator

@xgouchet xgouchet commented Oct 2, 2024

What does this PR do?

This updates how we compute our API coverage through Integration tests, by ignoring methods flagged with @Internal and Extension methods we use for non Datadog classes.

Motivation

Improve our visibility on integration test coverage

@xgouchet xgouchet force-pushed the xgouchet/reliability/it_api_coverage branch from cbd32f9 to b13283e Compare October 2, 2024 07:42
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.25%. Comparing base (21025fd) to head (6d6ea18).
Report is 30 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2300      +/-   ##
===========================================
- Coverage    70.44%   70.25%   -0.19%     
===========================================
  Files          730      730              
  Lines        27268    27265       -3     
  Branches      4584     4584              
===========================================
- Hits         19207    19153      -54     
- Misses        6815     6830      +15     
- Partials      1246     1282      +36     

see 25 files with indirect coverage changes

@xgouchet xgouchet marked this pull request as ready for review October 2, 2024 10:02
@xgouchet xgouchet requested review from a team as code owners October 2, 2024 10:02
@xgouchet xgouchet marked this pull request as draft October 2, 2024 10:03
@xgouchet xgouchet force-pushed the xgouchet/reliability/it_api_coverage branch 3 times, most recently from c555f74 to 01bbfec Compare October 3, 2024 08:53
@xgouchet xgouchet force-pushed the xgouchet/reliability/it_api_coverage branch from 01bbfec to 6d6ea18 Compare October 8, 2024 13:36
@xgouchet xgouchet marked this pull request as ready for review October 8, 2024 13:38
@xgouchet xgouchet merged commit 4b83197 into develop Oct 9, 2024
24 checks passed
@xgouchet xgouchet deleted the xgouchet/reliability/it_api_coverage branch October 9, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants