Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: use Java 11 bytecode for public modules #2315

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

0xnm
Copy link
Contributor

@0xnm 0xnm commented Oct 8, 2024

What does this PR do?

I noticed that some public modules were inconsistent in terms of the Java bytecode version produced, they had Java 17. Fixing it to align with other modules, to use Java 11.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.36%. Comparing base (d9b0432) to head (064f219).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2315      +/-   ##
===========================================
+ Coverage    70.32%   70.36%   +0.04%     
===========================================
  Files          736      736              
  Lines        27465    27466       +1     
  Branches      4607     4607              
===========================================
+ Hits         19313    19325      +12     
+ Misses        6863     6856       -7     
+ Partials      1289     1285       -4     

see 30 files with indirect coverage changes

@0xnm 0xnm marked this pull request as ready for review October 8, 2024 14:32
@0xnm 0xnm requested review from a team as code owners October 8, 2024 14:32
@0xnm 0xnm merged commit 4fce2ac into develop Oct 8, 2024
23 checks passed
@0xnm 0xnm deleted the nogorodnikov/use-java11-bytecode-for-public-modules branch October 8, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants