Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-3469: Resolve PorterDuffColorFilter case in drawable to color mapper #2319

Merged

Conversation

ambushwork
Copy link
Contributor

What does this PR do?

In lower version of Android, the color information is stored in paint.colorFilter instead of paint,
So we need to retrieve it from colorFilter.mColor attribute to have the correct color for drawable.

Motivation

RUM-3469

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 23.07692% with 20 lines in your changes missing coverage. Please review.

Project coverage is 70.23%. Comparing base (489655b) to head (d9097b8).
Report is 2 commits behind head on feature/sr-integration-test.

Files with missing lines Patch % Lines
...sessionreplay/utils/LegacyDrawableToColorMapper.kt 23.08% 19 Missing and 1 partial ⚠️
Additional details and impacted files
@@                       Coverage Diff                       @@
##           feature/sr-integration-test    #2319      +/-   ##
===============================================================
- Coverage                        70.30%   70.23%   -0.07%     
===============================================================
  Files                              736      736              
  Lines                            27465    27490      +25     
  Branches                          4607     4608       +1     
===============================================================
- Hits                             19308    19307       -1     
- Misses                            6876     6891      +15     
- Partials                          1281     1292      +11     
Files with missing lines Coverage Δ
...sessionreplay/utils/LegacyDrawableToColorMapper.kt 46.43% <23.08%> (-11.90%) ⬇️

... and 32 files with indirect coverage changes

@ambushwork ambushwork marked this pull request as ready for review October 11, 2024 08:42
@ambushwork ambushwork requested review from a team as code owners October 11, 2024 08:42
@ambushwork ambushwork merged commit 995b82c into feature/sr-integration-test Oct 11, 2024
23 checks passed
@ambushwork ambushwork deleted the yl/it/fix-drawable-to-color-issue branch October 11, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants