fix: Fix distributed tracing for web #664
Open
+683
−425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Web doesn't actually use our http tracking module, but the tests for http tracking live in that module. To ensure we don't break things in web distributed tracing, add web as an integration test platform to that package. Additionally, add sanity tests for the Dio, which we assume works because it uses HttpOverrides on mobile (which our plugin intercepts) and XMLHttpRequest on web (which the Browser SDK intercepts). Adding an integration test to ensure it's working on all supported platforms and that we don't break it moving forward. refs: #663
Web was not properly adding the trace sample rate, nor was it properly checking the `firstPartyHost` against the requested URL correctly. Both of these are fixed. Added `traceContextInjection` support. Refactor the integration test to use a single code path to simplify the widgets.
fuzzybinary
force-pushed
the
jward/web-tracking-test
branch
from
d823695
to
4c9eff6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Web was not properly adding the trace sample rate, nor was it properly checking the
firstPartyHostagainst the requested URL correctly. Both of these are fixed.As part of this, I added web as a platform on the tracing package. Web doesn't actually use our http tracking module, but the tests for http tracking live in that module.
Additionally, add sanity tests for the Dio, which we assume works because it uses HttpOverrides on mobile (which our plugin intercepts) and XMLHttpRequest on web (which the Browser SDK intercepts). Adding an integration test to ensure it's working on all supported platforms and that we don't break it moving forward.
refs: #663
Review checklist