contrib/aws/aws-sdk-go-v2/aws: Adding LoadOptionsFunc implementation #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcarbone
force-pushed
the
dcarbone/aws-load-options
branch
from
901f2b6
to
3eae656
Compare
rarguelloF
changed the title
- addresses DataDog#2094
dcarbone
force-pushed
the
dcarbone/aws-load-options
branch
from
c3a1370
to
f032efa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Addresses #2094 by adding a
WithDataDogTracerfunc that adheres to the AWS SDK Go V2config.LoadOptionFunctype.Motivation
I need to be able to configure the DD Tracer without directly having access to a config type.
Describe how to test/QA your changes
It functions identically to the current
AppendMiddlewarefunc, but appends to theAPIOptionspresent on theLoadOptionstype instead of the config type directly.Reviewer's Checklist