-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add crashtracker #2763
Add crashtracker #2763
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2763 +/- ##
============================================
- Coverage 81.07% 73.97% -7.10%
Complexity 2516 2516
============================================
Files 146 173 +27
Lines 14650 18679 +4029
Branches 0 975 +975
============================================
+ Hits 11877 13818 +1941
- Misses 2773 4324 +1551
- Partials 0 537 +537
Flags with carried forward coverage won't be shown. Click here to find out more. see 36 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
BenchmarksBenchmark execution time: 2024-08-20 08:30:06 Comparing candidate commit b8098a9 in PR branch Found 14 performance improvements and 0 performance regressions! Performance is the same for 164 metrics, 0 unstable metrics. scenario:EmptyFileBench/benchEmptyFileBaseline
scenario:EmptyFileBench/benchEmptyFileBaseline-opcache
scenario:EmptyFileBench/benchEmptyFileOverhead
scenario:EmptyFileBench/benchEmptyFileOverhead-opcache
scenario:LaravelBench/benchLaravelBaseline
scenario:LaravelBench/benchLaravelBaseline-opcache
scenario:LaravelBench/benchLaravelOverhead
scenario:LaravelBench/benchLaravelOverhead-opcache
scenario:SymfonyBench/benchSymfonyBaseline
scenario:SymfonyBench/benchSymfonyBaseline-opcache
scenario:SymfonyBench/benchSymfonyOverhead
scenario:SymfonyBench/benchSymfonyOverhead-opcache
scenario:WordPressBench/benchWordPressOverhead
scenario:WordPressBench/benchWordPressOverhead-opcache
|
395a56a
to
a04c57d
Compare
86bb2b7
to
68a1bbf
Compare
8c12ab9
to
4279522
Compare
2c8be7c
to
a7bbb4d
Compare
tests/ext/crashtracker_segfault.phpt
Outdated
if (getenv('SKIP_ASAN') || getenv('USE_ZEND_ALLOC') === '0') die("skip: intentionally causes segfaults"); | ||
if (getenv('PHP_PEAR_RUNTESTS') === '1') die("skip: pecl run-tests does not support XFAIL"); | ||
if (getenv('DD_TRACE_CLI_ENABLED') === '0') die("skip: tracer is disabled"); | ||
if (file_exists("/etc/os-release") && preg_match("/alpine/i", file_get_contents("/etc/os-release"))) die("skip Unsupported LIBC"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this for this test or does alpine generally not support crashtracking?
Signed-off-by: Bob Weinand <[email protected]>
a7bbb4d
to
ef15f6f
Compare
46ce8be
to
2ffc807
Compare
Signed-off-by: Bob Weinand <[email protected]>
2ffc807
to
bcbb017
Compare
Signed-off-by: Bob Weinand <[email protected]>
bcbb017
to
f9af56c
Compare
Signed-off-by: Bob Weinand <[email protected]>
Signed-off-by: Bob Weinand <[email protected]>
bd02024
to
3738163
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready for merge!
Description
Need DataDog/libdatadog#535
Reviewer checklist