Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crashtracker #2763

Merged
merged 34 commits into from
Aug 27, 2024
Merged

Add crashtracker #2763

merged 34 commits into from
Aug 27, 2024

Conversation

iamluc
Copy link
Contributor

@iamluc iamluc commented Jul 18, 2024

Description

Need DataDog/libdatadog#535

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.97%. Comparing base (81a708f) to head (3738163).

❗ There is a different number of reports uploaded between BASE (81a708f) and HEAD (3738163). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (81a708f) HEAD (3738163)
tracer-php 12 11
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2763      +/-   ##
============================================
- Coverage     81.07%   73.97%   -7.10%     
  Complexity     2516     2516              
============================================
  Files           146      173      +27     
  Lines         14650    18679    +4029     
  Branches          0      975     +975     
============================================
+ Hits          11877    13818    +1941     
- Misses         2773     4324    +1551     
- Partials          0      537     +537     
Flag Coverage Δ
appsec-extension 69.12% <ø> (?)
tracer-extension 78.19% <ø> (ø)
tracer-php 74.10% <ø> (-8.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 36 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81a708f...3738163. Read the comment docs.

@pr-commenter
Copy link

pr-commenter bot commented Jul 18, 2024

Benchmarks

Benchmark execution time: 2024-08-20 08:30:06

Comparing candidate commit b8098a9 in PR branch luc/crashtracker with baseline commit d75a84d in branch master.

Found 14 performance improvements and 0 performance regressions! Performance is the same for 164 metrics, 0 unstable metrics.

scenario:EmptyFileBench/benchEmptyFileBaseline

  • 🟩 execution_time [-515.368µs; -339.932µs] or [-17.893%; -11.802%]

scenario:EmptyFileBench/benchEmptyFileBaseline-opcache

  • 🟩 execution_time [-515.619µs; -314.081µs] or [-17.205%; -10.480%]

scenario:EmptyFileBench/benchEmptyFileOverhead

  • 🟩 execution_time [-614.655µs; -418.865µs] or [-18.923%; -12.896%]

scenario:EmptyFileBench/benchEmptyFileOverhead-opcache

  • 🟩 execution_time [-605.577µs; -435.963µs] or [-18.270%; -13.153%]

scenario:LaravelBench/benchLaravelBaseline

  • 🟩 execution_time [-492.131µs; -300.629µs] or [-16.307%; -9.961%]

scenario:LaravelBench/benchLaravelBaseline-opcache

  • 🟩 execution_time [-484.379µs; -262.801µs] or [-15.599%; -8.463%]

scenario:LaravelBench/benchLaravelOverhead

  • 🟩 execution_time [-543.879µs; -379.681µs] or [-16.210%; -11.316%]

scenario:LaravelBench/benchLaravelOverhead-opcache

  • 🟩 execution_time [-621.550µs; -436.310µs] or [-17.636%; -12.380%]

scenario:SymfonyBench/benchSymfonyBaseline

  • 🟩 execution_time [-406.953µs; -361.167µs] or [-6.862%; -6.090%]

scenario:SymfonyBench/benchSymfonyBaseline-opcache

  • 🟩 execution_time [-375.610µs; -323.290µs] or [-6.224%; -5.357%]

scenario:SymfonyBench/benchSymfonyOverhead

  • 🟩 execution_time [-847.056µs; -766.524µs] or [-12.278%; -11.111%]

scenario:SymfonyBench/benchSymfonyOverhead-opcache

  • 🟩 execution_time [-805.494µs; -729.406µs] or [-11.508%; -10.421%]

scenario:WordPressBench/benchWordPressOverhead

  • 🟩 execution_time [-10.477ms; -8.417ms] or [-4.908%; -3.943%]

scenario:WordPressBench/benchWordPressOverhead-opcache

  • 🟩 execution_time [-11.201ms; -7.988ms] or [-5.232%; -3.732%]

@iamluc iamluc force-pushed the luc/crashtracker branch 7 times, most recently from 395a56a to a04c57d Compare July 24, 2024 10:02
@iamluc iamluc force-pushed the luc/crashtracker branch 5 times, most recently from 86bb2b7 to 68a1bbf Compare August 19, 2024 16:01
@iamluc iamluc force-pushed the luc/crashtracker branch 6 times, most recently from 8c12ab9 to 4279522 Compare August 21, 2024 14:09
Makefile Outdated Show resolved Hide resolved
if (getenv('SKIP_ASAN') || getenv('USE_ZEND_ALLOC') === '0') die("skip: intentionally causes segfaults");
if (getenv('PHP_PEAR_RUNTESTS') === '1') die("skip: pecl run-tests does not support XFAIL");
if (getenv('DD_TRACE_CLI_ENABLED') === '0') die("skip: tracer is disabled");
if (file_exists("/etc/os-release") && preg_match("/alpine/i", file_get_contents("/etc/os-release"))) die("skip Unsupported LIBC");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for this test or does alpine generally not support crashtracking?

@bwoebi bwoebi force-pushed the luc/crashtracker branch 4 times, most recently from 46ce8be to 2ffc807 Compare August 23, 2024 14:53
Signed-off-by: Bob Weinand <[email protected]>
Signed-off-by: Bob Weinand <[email protected]>
@bwoebi bwoebi changed the title Init crashtracker Add crashtracker Aug 26, 2024
@iamluc iamluc marked this pull request as ready for review August 27, 2024 08:48
@iamluc iamluc requested review from a team as code owners August 27, 2024 08:48
Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for merge!

@iamluc iamluc merged commit 5c8a742 into master Aug 27, 2024
669 of 694 checks passed
@iamluc iamluc deleted the luc/crashtracker branch August 27, 2024 11:59
@github-actions github-actions bot added this to the 1.3.0 milestone Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants