Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTINT-3688] Enable origin detection from client when origin detection is enabled #1297

Merged
merged 4 commits into from
Feb 19, 2024

Conversation

AliDatadog
Copy link
Contributor

What this PR does / why we need it:

This PR sets the variable DD_DOGSTATSD_ORIGIN_DETECTION_ENABLED to true when dsd origin detection is enabled. Without it, we can't retrieve container tags on UDP even if the container-id is sent with metrics. https://github.com/DataDog/datadog-agent/blob/54e9ed2fde3620f8fe8181491f3ecc198538900a/comp/dogstatsd/server/parse.go#L70

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md
  • For Datadog Operator chart or value changes update the test baselines (run: make update-test-baselines)

@AliDatadog AliDatadog added the chart/datadog This issue or pull request is related to the datadog chart label Jan 19, 2024
@AliDatadog AliDatadog requested a review from a team as a code owner January 19, 2024 10:54
@AliDatadog
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 19, 2024

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@AliDatadog AliDatadog merged commit 6c78e69 into main Feb 19, 2024
16 checks passed
@AliDatadog AliDatadog deleted the ali/origin-detection-client branch February 19, 2024 13:16
@dd-devflow
Copy link

dd-devflow bot commented Feb 19, 2024

🚂 MergeQueue

This pull request was merged directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart/datadog This issue or pull request is related to the datadog chart mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants