-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable mutations on Datadog resources pods #1330
Disable mutations on Datadog resources pods #1330
Conversation
@@ -8,6 +8,7 @@ metadata: | |||
labels: | |||
{{ include "datadog.labels" . | indent 4 }} | |||
app.kubernetes.io/component: cluster-agent | |||
admission.datadoghq.com/enabled: "false" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is in the Deployment.spec.template.metadata.labels that the label needs to be added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, forgot to remove this line after testing the label is not inherited by pods.
/merge |
❌ MergeQueue You are not allowed to use the merge queue towards If you need support, contact us on Slack #ci-interfaces with those details! |
/merge |
🚂 MergeQueue This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
🚂 MergeQueue Added to the queue. This build is going to start soon! (estimated merge in less than 0s) Use |
❌ MergeQueue The merge has been interrupted. The current limit on the base branch 'main' is 120 minutes. If you need support, contact us on Slack #ci-interfaces with those details! |
What this PR does / why we need it:
Exclude the agent, cluster agent and clusterchecks pods from any kind of mutation performed by the Admission Controller. With this change Admission Controllers will not inject configs, tags or tracing libraries into DD resources.
Agent pod for latest helm-chart:
Agent pod with PR's change:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
.github/helm-docs.sh
)CHANGELOG.md
has been updatedREADME.md
make update-test-baselines
)