Tests for private action runner helm chart #1532
Draft
+509
−62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I initially wanted to do it in #1529 but I found out that my implementation
was only making assertions on the service-account, all other resources were not checked. I believe this is due to the fact that
common.Unmarshal(t, manifest, &actual)
andcommon.LoadFromFile(t, baselineManifestPath, &baseline)
actually only read the first entry from the yaml and ignores the following ones (not 100% sure about this but it matches my observation)helm-charts/test/private-action-runner/baseline_test.go
Lines 67 to 81 in 8a47e13
helm-charts/test/private-action-runner/baseline/Private_Action_Runner_default.yaml
Lines 1 to 27 in 8a47e13
the tests were not running on the pull request because the only github workflow running unit test is restricted to
test/datadog-operator/**
andcharts/datadog-operator/**
pathsSpecial notes for your reviewer:
I'm not 100% sure of the best path forward about this.
helm.DiffAgainstSnapshot
which made bump a few dependencies.