Allow updateMap to use custom sourceFile and mappingFile #1588
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add support to the
-updateMap
flag to update providedmappingFile
with a providedsourceFile
so that it can be used more generically in development and CI.Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer:
QA
295
to print tmp file paths and build yaml-mapper binary./yaml-mapper -updateMap
with no flags should update default mappingFile with values from the latest Datadog chart values.yaml:mapping_datadog_helm_to_datadogagent_crd.yaml
and run./yaml-mapper -updateMap
. The helm keys should be added back to the default mapping file. (i.e. removeagents.containers.agent.envDict: ""
)./yaml-mapper -updateMap -sourceFile=<path-to-local-helm-charts-dir>/charts/datadog/values.yaml
should update the default mappingFile with any new keys added to the local values.yaml file./yaml-mapper -updateMap -sourceFile=<path-to-local-helm-charts-dir>/charts/datadog/values.yaml -mappingFile=<other-mapping-file>
should update provided mappingFile with keys from the local values.yaml file./yaml-mapper -updateMap -sourceFile=<any.yaml> -mappingFile=<some-mapping-file>
should map keys from any yaml file to a provided mapping file-sourceFile
flag is used , make sure providedsourceFile
doesn't get deleted!Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
.github/helm-docs.sh
)CHANGELOG.md
has been updatedREADME.md
make update-test-baselines
)