Bump KSM chart version to use rbac.authorization.k8s.io/v1

[L3n41c]

What this PR does / why we need it:

Bump the version of the KSM chart.

Which issue this PR fixes

When we install the datadog chart, Helm produces the following warnings:

W0315 15:51:01.542249   64621 warnings.go:70] rbac.authorization.k8s.io/v1beta1 ClusterRole is deprecated in v1.17+, unavailable in v1.22+; use rbac.authorization.k8s.io/v1 ClusterRole
W0315 15:51:01.594559   64621 warnings.go:70] rbac.authorization.k8s.io/v1beta1 ClusterRole is deprecated in v1.17+, unavailable in v1.22+; use rbac.authorization.k8s.io/v1 ClusterRole
W0315 15:51:01.647086   64621 warnings.go:70] rbac.authorization.k8s.io/v1beta1 ClusterRole is deprecated in v1.17+, unavailable in v1.22+; use rbac.authorization.k8s.io/v1 ClusterRole
W0315 15:51:02.684250   64621 warnings.go:70] rbac.authorization.k8s.io/v1beta1 ClusterRoleBinding is deprecated in v1.17+, unavailable in v1.22+; use rbac.authorization.k8s.io/v1 ClusterRoleBinding
W0315 15:51:02.739027   64621 warnings.go:70] rbac.authorization.k8s.io/v1beta1 ClusterRoleBinding is deprecated in v1.17+, unavailable in v1.22+; use rbac.authorization.k8s.io/v1 ClusterRoleBinding
W0315 15:51:02.792100   64621 warnings.go:70] rbac.authorization.k8s.io/v1beta1 ClusterRoleBinding is deprecated in v1.17+, unavailable in v1.22+; use rbac.authorization.k8s.io/v1 ClusterRoleBinding

These errors are coming from the kube-state-metrics chart.
Whereas the datadog chart is able to automatically choose the right version of the RBAC API to use, the KSM chart switched from v1beta1 to v1 at this commit.

• Fixes rbac deprecation notice when installing helm chart #153

Special notes for your reviewer:

Whereas there is a mechanism to include or not a dependency based on a .Value.… value, I couldn’t find a way to include a dependency based on a .Capabilities.… object.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
• Chart Version bumped
• CHANGELOG.md has beed updated
• Variables are documented in the README.md

[vboulineau]

I've exactly the same PR locally :D. I think your requirements.lock has not been generated by Helm2 though and there are several places in the CI to update to new chart repo.

[L3n41c]

Indeed, my requirements.lock has been generated by Helm3. Is it an issue ?

[clamoriniere]

Indeed, my requirements.lock has been generated by Helm3. Is it an issue ?

yes because the hash is not generated the same way.

helm2 and 3 can understand hash generated by helm2.
but not the opposite

previous issue: #56

[vboulineau]

I think stable can be removed, was only used for KSM

[vboulineau]

Also you need to update .github/ct.yaml

[L3n41c]

Indeed!

[SebastianWilhelm]

After the change of the KSM repo, that came with this PR, we can't pull images on AKS in Azure China:

Failed to pull image "k8s.gcr.io/kube-state-metrics/kube-state-metrics:v1.9.8": rpc error: code = Unknown desc = Error response from daemon: Get https://k8s.gcr.io/v2/: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)

Can we overwrite the repo for KSM in the values.yaml somehow?

[vboulineau]

Hi @SebastianWilhelm,

Yes, you can specify a repository and tags for Kube State Metrics through:
https://github.com/kubernetes/kube-state-metrics/blob/master/charts/kube-state-metrics/values.yaml#L3-L6

In this chart values.yaml, this would be:

kube-state-metrics:
  image:
    repository: <your_repo>
    tag: v1.9.8 # If you do not use the same as upstream

[SebastianWilhelm]

Hi @SebastianWilhelm,

Yes, you can specify a repository and tags for Kube State Metrics through:
https://github.com/kubernetes/kube-state-metrics/blob/master/charts/kube-state-metrics/values.yaml#L3-L6

In this chart values.yaml, this would be:

kube-state-metrics:
  image:
    repository: <your_repo>
    tag: v1.9.8 # If you do not use the same as upstream

Ah right. That helped. Many thanks.