Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for sending sample_rate while submitting metrics #9

Closed
debraj-manna opened this issue Jun 20, 2016 · 7 comments
Closed

Add support for sending sample_rate while submitting metrics #9

debraj-manna opened this issue Jun 20, 2016 · 7 comments
Milestone
2.3

Comments

@debraj-manna
Copy link
Contributor

Add support for sending sample_rate while submitting metrics to datadog.
@gcuni
Copy link

gcuni commented Jul 22, 2016

https://github.com/arnabk/java-dogstatsd-client/ recently added this functionality. It would be great if you guys added it too if this is supposed to be the "official" dogstatsd library

@irabinovitch
Copy link
Contributor

@gcuni Thanks for the pointer. Lets reach out to @arnabk and if they'd be willing to submit a PR here.

@arnabk
Copy link

arnabk commented Jul 22, 2016 •
edited
Loading

@debraj-manna Just submit similar PR to this fork (arnabk/java-dogstatsd-client#3)
Whoever owns this repo, they can also diff this fork with mine and get all the changes. So a new PR is not needed

@gcuni
Copy link

gcuni commented Jul 22, 2016

It would also be great if the additional methods with the sample rate parameter were added to the StatsDClient interface. For testing and other reasons, some people might prefer to hold references to the interface instead of the implementation.

@debraj-manna
Copy link
Contributor Author

Ok I will have a look at it.

Sent from GMail on Android

On Jul 23, 2016 12:05 AM, "Arnab Karmakar" [email protected] wrote:

@debraj-manna https://github.com/debraj-manna Just submit similar PR to
this fork (arnabk#3
arnabk/java-dogstatsd-client#3)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#9 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHw8JNGrl3NDF390GMqRJ48HXI5cX7GFks5qYQ1UgaJpZM4I5fuJ
.

debraj-spotnana pushed a commit to debraj-spotnana/java-dogstatsd-client that referenced this issue Aug 16, 2016
Add additional methods with sampleRate to StatsDClient interface
9a2f8a4 
Refer this
[link](DataDog/java-dogstatsd-client#9 (comment)
mment-234621887) for more.
@debraj-spotnana debraj-spotnana mentioned this issue Aug 16, 2016
Merged
@debraj-manna
Copy link
Contributor Author

Additional methods have been added in StatsDClient interface under
java-dogstatsd-client
arnabk/java-dogstatsd-client#7.

On Sun, Jul 24, 2016 at 8:52 AM, DEBRAJ MANNA [email protected] wrote:

Ok I will have a look at it.

Sent from GMail on Android

On Jul 23, 2016 12:05 AM, "Arnab Karmakar" [email protected]
wrote:

@debraj-manna https://github.com/debraj-manna Just submit similar PR
to this fork (arnabk#3
arnabk/java-dogstatsd-client#3)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#9 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHw8JNGrl3NDF390GMqRJ48HXI5cX7GFks5qYQ1UgaJpZM4I5fuJ
.

Debraj Manna

@debraj-manna debraj-manna mentioned this issue Aug 17, 2016
Merged
@debraj-manna
Copy link
Contributor Author

Submitted the below PR

#11

Sent from GMail on Android

On Aug 17, 2016 3:44 PM, "DEBRAJ MANNA" [email protected] wrote:

Additional methods have been added in StatsDClient interface under
java-dogstatsd-client
arnabk/java-dogstatsd-client#7.

On Sun, Jul 24, 2016 at 8:52 AM, DEBRAJ MANNA [email protected]
wrote:

Ok I will have a look at it.

Sent from GMail on Android

On Jul 23, 2016 12:05 AM, "Arnab Karmakar" [email protected]
wrote:

@debraj-manna https://github.com/debraj-manna Just submit similar PR
to this fork (arnabk#3
arnabk/java-dogstatsd-client#3)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#9 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHw8JNGrl3NDF390GMqRJ48HXI5cX7GFks5qYQ1UgaJpZM4I5fuJ
.

Debraj Manna

@masci masci added this to the 2.3 milestone Aug 26, 2016
masci pushed a commit that referenced this issue Aug 26, 2016
@debraj-manna @masci
Add sampleRate while submitting metrics to datadog (#11)
37fbddf 
Refer
[Issue-9](#9)
for more
@masci masci closed this as completed Oct 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3
Development

No branches or pull requests
5 participants
@masci @irabinovitch @arnabk @debraj-manna @gcuni