Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sampling] sampling on counts to be disabled when aggregation is enabled. #127

Merged
merged 2 commits into from
Nov 17, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/main/java/com/timgroup/statsd/NonBlockingStatsDClient.java
Original file line number Diff line number Diff line change
Expand Up @@ -1145,6 +1145,16 @@ private void send(final Message message) {

// send double with sample rate
private void send(String aspect, final double value, Message.Type type, double sampleRate, String[] tags) {
if (statsDProcessor.getAggregator().getFlushInterval() != 0 && !Double.isNaN(sampleRate)) {
switch (type) {
case COUNT:
sampleRate = Double.NaN;
break;
default:
break;
}
}

if (Double.isNaN(sampleRate) || !isInvalidSample(sampleRate)) {

sendMetric(new StatsDMessage<Double>(aspect, type, Double.valueOf(value), sampleRate, tags) {
Expand All @@ -1162,6 +1172,16 @@ private void send(String aspect, final double value, Message.Type type, String[]

// send long with sample rate
private void send(String aspect, final long value, Message.Type type, double sampleRate, String[] tags) {
if (statsDProcessor.getAggregator().getFlushInterval() != 0 && !Double.isNaN(sampleRate)) {
switch (type) {
case COUNT:
sampleRate = Double.NaN;
break;
default:
break;
}
}

if (Double.isNaN(sampleRate) || !isInvalidSample(sampleRate)) {
sendMetric(new StatsDMessage<Long>(aspect, type, value, sampleRate, tags) {
@Override protected void writeValue(StringBuilder builder) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1114,6 +1114,41 @@ public void testBasicCountAggregation() throws Exception {
}
}

@Test(timeout=5000L)
public void testSampledCountAggregation() throws Exception {
final RecordingErrorHandler errorHandler = new RecordingErrorHandler();
final NonBlockingStatsDClient testClient = new NonBlockingStatsDClientBuilder()
.prefix("my.prefix")
.hostname("localhost")
.port(STATSD_SERVER_PORT)
.enableTelemetry(false) // don't want additional packets
.enableAggregation(true)
.aggregationFlushInterval(3000)
.errorHandler(errorHandler)
.build();

try {
for (int i=0 ; i<10 ; i++) {
// NOTE: because aggregation is enabled, sampling is disabled, so all
// counts should be accounted for, as if sample rate were 1.0.
testClient.count("top.level.count", i, 0.1);
}
for (int i=0 ; i<10 ; i++) {
testClient.increment("top.level.count");
}

server.waitForMessage("my.prefix");

List<String> messages = server.messagesReceived();

assertThat(messages.size(), comparesEqualTo(1));
assertThat(messages, hasItem(comparesEqualTo("my.prefix.top.level.count:55|c")));

} finally {
testClient.stop();
}
}

@Test(timeout=5000L)
public void testBasicSetAggregation() throws Exception {
final RecordingErrorHandler errorHandler = new RecordingErrorHandler();
Expand Down