[aggregator] fix thread leak + dont always start scheduler #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
truthbk
commented
Nov 20, 2020
truthbk
commented
- Let's not start the timer thread unless we have the aggregator actually enabled.
- Ensure the scheduler is stopped when the aggregator is shut down.
prognant
approved these changes
Nov 23, 2020
Comment on lines
31
to
32
| // protected final Map<Message, Message> aggregateMetrics = new HashMap<>(); | ||
| // protected final Timer scheduler = new Timer(AGGREGATOR_THREAD_NAME, true); |
There was a problem hiding this comment.
Shouldn't we remove those two lines ?
truthbk
force-pushed
the
jaime/aggrleak
branch
4 times, most recently
from
dc80b7e
to
dcab4c4
Compare
truthbk
force-pushed
the
jaime/aggrleak
branch
from
dcab4c4
to
6659674
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.