[client] enable aggregation by default #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Got to fix the perf tests, but the actual client code is reviewable. Will push the fix soon. |
[test] adding missing test file
truthbk
force-pushed
the
jaime/aggregation_default
branch
from
92a3515
to
26383c0
Compare
vickenty
approved these changes
Sep 29, 2021
vickenty
added a commit
that referenced
this pull request
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will set aggregation for simple types by default, this would reduce the overall packet traffic to the server. The goal is to reduce the overall load on the dogstatsd client-server environments. Aggregation comes with a slight overhead on the client side, but it's clearly offset by the gains on the server side.
Please note that this PR has the effect of making metric submission with sample rates ineffectual as they make no sense in the context of metric aggregation. In practice, the metric is just aggregated and the sampling is just ignored.