Reducing buffer size to 1400 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch @KotaiVictor thanks! |
This was referenced Feb 23, 2017
|
Shouldn't the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Were using the NonBlockingStatsDClient to push to a statsD_exporter endpoint that prometheus picks up from.
We've noticed that we were dropping a lot of data, although we were sending it correctly.
Looking into it it seemed to be that the size of the packets was too big.
Given how the message buffer gets filled up; in the case where it was getting close to the 1500 mark, the addition of the ethernet/udp headers was pushing it past the MTU size causing fragmentation.