Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add third-party license information #179

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Add third-party license information #179

merged 1 commit into from
Jan 5, 2022

Conversation

vickenty
Copy link
Contributor

Add a NOTICE file to the binary distribution that details license
situation for each subdirectory containing third-party code. This file
should fullfill our obligations when distributing third-party code in
the jar-with-dependencies package.

Provide a more compact overview in THIRDPARTY.md.

Add a script that was used to generate the two files above.

Add a NOTICE file to the binary distribution that details license
situation for each subdirectory containing third-party code. This file
should fullfill our obligations when distributing third-party code in
the jar-with-dependencies package.

Provide a more compact overview in THIRDPARTY.md.

Add a script that was used to generate the two files above.
Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this. I'm a bit hesitant to add a python script to the repo, but if there's no tooling (mvn plugin or whatever) we can harness to produce a similar notice, then I guess it's OK.

@vickenty
Copy link
Contributor Author

vickenty commented Jan 5, 2022

Not happy about that too, but I couldn't find anything that would do it for us. There is this maven plugin, but I couldn't get it to do what we need here.

@vickenty vickenty merged commit d5028c9 into master Jan 5, 2022
@vickenty vickenty deleted the vickenty/third branch January 6, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants