-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement fallback for when memfd is not available on Linux #591
Conversation
BenchmarksComparisonBenchmark execution time: 2024-08-22 19:02:21 Comparing candidate commit 6ee4339 in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 48 metrics, 2 unstable metrics. scenario:credit_card/is_card_number_no_luhn/378282246310005
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
BaselineOmitted due to size. |
bd19a39
to
cad4926
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #591 +/- ##
==========================================
- Coverage 72.86% 72.75% -0.11%
==========================================
Files 241 241
Lines 34366 34427 +61
==========================================
+ Hits 25040 25047 +7
- Misses 9326 9380 +54
|
WSL is a "Linux" environment, but it does not support the memfd_create syscall. Thus we fall back to other strategies here. Signed-off-by: Bob Weinand <[email protected]>
3366854
to
bad0fc8
Compare
Signed-off-by: Bob Weinand <[email protected]>
bad0fc8
to
6ee4339
Compare
WSL is a "Linux" environment, but it does not support the memfd_create syscall. Thus we fall back to other strategies here.