-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix log file and disable LSAN usage in sidecar #602
Conversation
bwoebi
commented
Aug 28, 2024
- Sidecar will leak some global structures, using LSAN there would either require an extensive suppressions list. For now we just opt to disable it. This avoids false positives in our testing we have to manually detect and ignore.
- Using an invalid log file should simply avoid sending it to the sidecar completely instead of failing there again, preventing two log messages for the same issue.
- Use _exit(0) instead of regular exit(0) when daemonizing to avoid sideeffects from atexit() handlers inherited from forking.
Like leak sanitizer running here; we definitely do not have cleaned up anything at this point.
Signed-off-by: Bob Weinand <[email protected]>
Signed-off-by: Bob Weinand <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #602 +/- ##
==========================================
- Coverage 72.84% 72.83% -0.01%
==========================================
Files 243 243
Lines 34681 34683 +2
==========================================
Hits 25263 25263
- Misses 9418 9420 +2
|
BenchmarksComparisonBenchmark execution time: 2024-08-29 15:13:08 Comparing candidate commit 2734124 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
BaselineOmitted due to size. |