Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing symbol ddog_crasht_demangle #611

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

gleocadie
Copy link
Contributor

@gleocadie gleocadie commented Sep 6, 2024

What does this PR do?

Ensure ddog_crasht_demangle is exported. Currently, it's not compiling/linking at all.

Motivation

Since #551, ddog_crasht_demangle is not exported anymore (not in v11 nor v12).

Additional Notes

How to test the change?

Added a call to ddog_crasht_demangle in the example.
+
Downloaded the artifacts and checked that the symbol is part of the library

╭─greg@DESKTOP-DQNLFF9 ~/repos/libdatadog/tmp  ‹gleocadie/add-crashtracking-feature-for-windows›
╰─➤  nm lib/libdatadog_profiling.so | grep ddog_crasht_demangle
00000000004f8710 T ddog_crasht_demangle

Next step

Add a test to check the exported functions.

@pr-commenter
Copy link

pr-commenter bot commented Sep 6, 2024

Benchmarks

Comparison

Benchmark execution time: 2024-09-10 15:06:20

Comparing candidate commit b960b4d in PR branch gleocadie/fix-missing-symbol-for-crashtracker with baseline commit 9705ec2 in branch main.

Found 1 performance improvements and 1 performance regressions! Performance is the same for 49 metrics, 2 unstable metrics.

scenario:redis/obfuscate_redis_string

  • 🟥 execution_time [+809.668ns; +1182.855ns] or [+2.256%; +3.295%]

scenario:tags/replace_trace_tags

  • 🟩 execution_time [-62.340ns; -55.400ns] or [-2.269%; -2.016%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b960b4d 1725980166 gleocadie/fix-missing-symbol-for-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 280.492µs 282.657µs ± 1.271µs 282.313µs ± 0.630µs 283.209µs 285.416µs 286.245µs 288.307µs 2.12% 1.482 2.399 0.45% 0.090µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3468530.264op/s 3537931.141op/s ± 15809.258op/s 3542170.332op/s ± 7899.830op/s 3548842.942op/s 3555117.523op/s 3556993.396op/s 3565160.563op/s 0.65% -1.453 2.273 0.45% 1117.883op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 27.505µs 27.784µs ± 0.091µs 27.800µs ± 0.047µs 27.845µs 27.896µs 27.933µs 27.988µs 0.68% -1.024 0.864 0.33% 0.006µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 35729333.446op/s 35992468.540op/s ± 118089.365op/s 35970612.741op/s ± 61136.055op/s 36036232.056op/s 36245797.867op/s 36338162.764op/s 36357025.995op/s 1.07% 1.042 0.900 0.33% 8350.179op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 16.811µs 16.861µs ± 0.030µs 16.855µs ± 0.020µs 16.879µs 16.918µs 16.942µs 16.988µs 0.79% 0.964 1.141 0.18% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 58863945.635op/s 59308942.673op/s ± 106073.901op/s 59330980.881op/s ± 70851.070op/s 59391884.498op/s 59440921.668op/s 59464804.269op/s 59485901.841op/s 0.26% -0.952 1.097 0.18% 7500.557op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [282.481µs; 282.833µs] or [-0.062%; +0.062%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3535740.130op/s; 3540122.152op/s] or [-0.062%; +0.062%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [27.771µs; 27.796µs] or [-0.045%; +0.045%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [35976102.490op/s; 36008834.591op/s] or [-0.045%; +0.045%] None None None
normalization/normalize_name/normalize_name/good execution_time [16.857µs; 16.865µs] or [-0.025%; +0.025%] None None None
normalization/normalize_name/normalize_name/good throughput [59294241.851op/s; 59323643.495op/s] or [-0.025%; +0.025%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b960b4d 1725980166 gleocadie/fix-missing-symbol-for-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.382µs 3.186µs ± 1.558µs 3.030µs ± 0.022µs 3.051µs 3.108µs 13.864µs 17.873µs 489.88% 7.979 64.323 48.78% 0.110µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.970µs; 3.402µs] or [-6.778%; +6.778%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b960b4d 1725980166 gleocadie/fix-missing-symbol-for-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 142.459µs 143.802µs ± 0.357µs 143.797µs ± 0.146µs 143.946µs 144.272µs 145.202µs 145.778µs 1.38% 0.962 7.195 0.25% 0.025µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [143.752µs; 143.851µs] or [-0.034%; +0.034%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b960b4d 1725980166 gleocadie/fix-missing-symbol-for-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.635µs 2.689µs ± 0.022µs 2.694µs ± 0.008µs 2.701µs 2.727µs 2.731µs 2.735µs 1.49% -0.483 0.046 0.80% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.686µs; 2.692µs] or [-0.111%; +0.111%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b960b4d 1725980166 gleocadie/fix-missing-symbol-for-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 72.672µs 72.844µs ± 0.121µs 72.834µs ± 0.034µs 72.866µs 72.941µs 73.046µs 74.335µs 2.06% 9.472 113.537 0.17% 0.009µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [72.827µs; 72.860µs] or [-0.023%; +0.023%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b960b4d 1725980166 gleocadie/fix-missing-symbol-for-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 8.894ms 8.921ms ± 0.020ms 8.919ms ± 0.007ms 8.926ms 8.942ms 8.954ms 9.160ms 2.69% 8.405 96.427 0.23% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [8.919ms; 8.924ms] or [-0.031%; +0.031%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b960b4d 1725980166 gleocadie/fix-missing-symbol-for-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 1.212µs 1.213µs ± 0.001µs 1.213µs ± 0.000µs 1.213µs 1.213µs 1.214µs 1.219µs 0.48% 5.779 57.459 0.05% 0.000µs 1 200
credit_card/is_card_number/ throughput 820626655.470op/s 824617714.701op/s ± 383681.737op/s 824594410.687op/s ± 197347.397op/s 824872893.359op/s 824988601.644op/s 825083123.225op/s 825277281.458op/s 0.08% -5.743 56.960 0.05% 27130.396op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 108.056µs 109.082µs ± 0.724µs 108.930µs ± 0.409µs 109.359µs 110.575µs 111.318µs 111.826µs 2.66% 1.407 2.096 0.66% 0.051µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 8942425.940op/s 9167825.778op/s ± 60257.704op/s 9180239.087op/s ± 34479.657op/s 9211890.586op/s 9235544.241op/s 9247658.301op/s 9254440.170op/s 0.81% -1.365 1.946 0.66% 4260.863op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 102.074µs 102.985µs ± 0.669µs 102.767µs ± 0.322µs 103.306µs 104.341µs 105.203µs 105.381µs 2.54% 1.344 1.509 0.65% 0.047µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 9489407.278op/s 9710541.094op/s ± 62569.791op/s 9730762.352op/s ± 30460.288op/s 9756471.923op/s 9776663.323op/s 9793339.065op/s 9796786.371op/s 0.68% -1.311 1.391 0.64% 4424.352op/s 1 200
credit_card/is_card_number/37828224631 execution_time 1.212µs 1.213µs ± 0.001µs 1.213µs ± 0.000µs 1.213µs 1.213µs 1.214µs 1.218µs 0.48% 4.409 38.538 0.05% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 820746055.876op/s 824637095.007op/s ± 411204.890op/s 824657406.460op/s ± 247499.919op/s 824923059.195op/s 825033338.220op/s 825102241.476op/s 825251185.267op/s 0.07% -4.378 38.138 0.05% 29076.577op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 98.402µs 99.379µs ± 0.631µs 99.225µs ± 0.345µs 99.721µs 100.648µs 101.266µs 101.467µs 2.26% 1.182 0.943 0.63% 0.045µs 1 200
credit_card/is_card_number/378282246310005 throughput 9855385.392op/s 10062916.801op/s ± 63389.869op/s 10078120.404op/s ± 35112.234op/s 10107961.538op/s 10133817.218op/s 10141255.085op/s 10162405.298op/s 0.84% -1.153 0.855 0.63% 4482.341op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 100.063µs 100.593µs ± 0.360µs 100.494µs ± 0.218µs 100.841µs 101.218µs 101.659µs 102.249µs 1.75% 1.220 1.995 0.36% 0.025µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 9780037.184op/s 9941217.694op/s ± 35453.974op/s 9950875.023op/s ± 21604.684op/s 9967964.458op/s 9981320.610op/s 9989493.226op/s 9993657.026op/s 0.43% -1.194 1.872 0.36% 2506.975op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 19.235µs 19.380µs ± 0.111µs 19.395µs ± 0.087µs 19.460µs 19.562µs 19.643µs 19.690µs 1.52% 0.441 -0.480 0.57% 0.008µs 1 200
credit_card/is_card_number/x371413321323331 throughput 50787932.866op/s 51600799.140op/s ± 295333.260op/s 51559891.971op/s ± 231444.028op/s 51909807.164op/s 51981465.327op/s 51985920.457op/s 51989570.186op/s 0.83% -0.418 -0.524 0.57% 20883.215op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 1.212µs 1.212µs ± 0.000µs 1.212µs ± 0.000µs 1.213µs 1.213µs 1.213µs 1.213µs 0.08% 0.288 -0.632 0.03% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 824093295.073op/s 824781045.260op/s ± 261650.214op/s 824749070.921op/s ± 211661.246op/s 825027673.033op/s 825141997.645op/s 825214302.673op/s 825221423.745op/s 0.06% -0.287 -0.634 0.03% 18501.464op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 88.868µs 90.210µs ± 0.524µs 90.188µs ± 0.326µs 90.516µs 91.089µs 91.653µs 91.901µs 1.90% 0.296 0.292 0.58% 0.037µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 10881273.338op/s 11085635.591op/s ± 64286.005op/s 11087996.558op/s ± 39919.192op/s 11127493.537op/s 11191310.643op/s 11220875.285op/s 11252677.754op/s 1.49% -0.258 0.254 0.58% 4545.707op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 83.198µs 84.917µs ± 0.559µs 85.003µs ± 0.362µs 85.315µs 85.741µs 85.921µs 86.174µs 1.38% -0.498 -0.003 0.66% 0.040µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 11604421.403op/s 11776670.102op/s ± 77741.509op/s 11764349.959op/s ± 50027.693op/s 11831659.184op/s 11916103.241op/s 11990616.429op/s 12019527.046op/s 2.17% 0.532 0.053 0.66% 5497.155op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 1.212µs 1.213µs ± 0.001µs 1.213µs ± 0.000µs 1.213µs 1.213µs 1.214µs 1.219µs 0.55% 5.477 52.442 0.05% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 820149808.860op/s 824637344.528op/s ± 440739.014op/s 824675259.923op/s ± 239808.967op/s 824917015.045op/s 825046944.617op/s 825124370.541op/s 825283310.244op/s 0.07% -5.438 51.904 0.05% 31164.955op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 79.933µs 81.305µs ± 0.472µs 81.324µs ± 0.321µs 81.633µs 82.062µs 82.261µs 82.478µs 1.42% -0.176 -0.303 0.58% 0.033µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 12124502.674op/s 12299747.261op/s ± 71545.667op/s 12296531.768op/s ± 48792.242op/s 12347498.051op/s 12415313.316op/s 12463219.273op/s 12510552.600op/s 1.74% 0.205 -0.287 0.58% 5059.043op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 100.086µs 100.501µs ± 0.294µs 100.439µs ± 0.188µs 100.699µs 101.075µs 101.296µs 101.394µs 0.95% 0.748 -0.119 0.29% 0.021µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 9862527.219op/s 9950230.608op/s ± 29038.944op/s 9956296.344op/s ± 18677.941op/s 9973307.689op/s 9988559.803op/s 9990377.069op/s 9991389.421op/s 0.35% -0.736 -0.143 0.29% 2053.363op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 19.231µs 19.404µs ± 0.120µs 19.405µs ± 0.084µs 19.483µs 19.634µs 19.647µs 19.703µs 1.54% 0.258 -0.796 0.62% 0.009µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 50753267.180op/s 51536744.500op/s ± 319073.201op/s 51533290.510op/s ± 224242.739op/s 51839142.324op/s 51985093.967op/s 51993761.198op/s 51998073.951op/s 0.90% -0.237 -0.819 0.62% 22561.882op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [1.213µs; 1.213µs] or [-0.006%; +0.006%] None None None
credit_card/is_card_number/ throughput [824564540.103op/s; 824670889.300op/s] or [-0.006%; +0.006%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [108.982µs; 109.182µs] or [-0.092%; +0.092%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [9159474.640op/s; 9176176.916op/s] or [-0.091%; +0.091%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [102.892µs; 103.078µs] or [-0.090%; +0.090%] None None None
credit_card/is_card_number/ 378282246310005 throughput [9701869.523op/s; 9719212.666op/s] or [-0.089%; +0.089%] None None None
credit_card/is_card_number/37828224631 execution_time [1.213µs; 1.213µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/37828224631 throughput [824580105.964op/s; 824694084.050op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/378282246310005 execution_time [99.291µs; 99.466µs] or [-0.088%; +0.088%] None None None
credit_card/is_card_number/378282246310005 throughput [10054131.575op/s; 10071702.027op/s] or [-0.087%; +0.087%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [100.543µs; 100.643µs] or [-0.050%; +0.050%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [9936304.114op/s; 9946131.274op/s] or [-0.049%; +0.049%] None None None
credit_card/is_card_number/x371413321323331 execution_time [19.365µs; 19.396µs] or [-0.080%; +0.080%] None None None
credit_card/is_card_number/x371413321323331 throughput [51559868.791op/s; 51641729.490op/s] or [-0.079%; +0.079%] None None None
credit_card/is_card_number_no_luhn/ execution_time [1.212µs; 1.212µs] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/ throughput [824744783.057op/s; 824817307.463op/s] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [90.137µs; 90.282µs] or [-0.080%; +0.080%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [11076726.169op/s; 11094545.012op/s] or [-0.080%; +0.080%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [84.840µs; 84.995µs] or [-0.091%; +0.091%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [11765895.877op/s; 11787444.328op/s] or [-0.091%; +0.091%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [1.213µs; 1.213µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [824576262.339op/s; 824698426.716op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [81.240µs; 81.371µs] or [-0.081%; +0.081%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [12289831.720op/s; 12309662.803op/s] or [-0.081%; +0.081%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [100.460µs; 100.542µs] or [-0.041%; +0.041%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [9946206.089op/s; 9954255.126op/s] or [-0.040%; +0.040%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [19.388µs; 19.421µs] or [-0.086%; +0.086%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [51492524.023op/s; 51580964.976op/s] or [-0.086%; +0.086%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b960b4d 1725980166 gleocadie/fix-missing-symbol-for-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.276µs 23.502µs ± 9.782µs 19.082µs ± 0.366µs 20.702µs 36.081µs 37.238µs 96.509µs 405.75% 3.835 22.363 41.52% 0.692µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [22.147µs; 24.858µs] or [-5.768%; +5.768%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b960b4d 1725980166 gleocadie/fix-missing-symbol-for-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 291.564ns 303.393ns ± 12.994ns 297.443ns ± 4.685ns 306.827ns 333.523ns 340.200ns 344.988ns 15.98% 1.413 1.145 4.27% 0.919ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [301.592ns; 305.194ns] or [-0.594%; +0.594%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b960b4d 1725980166 gleocadie/fix-missing-symbol-for-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 578.467µs 579.655µs ± 0.352µs 579.676µs ± 0.227µs 579.899µs 580.170µs 580.427µs 580.902µs 0.21% -0.156 0.911 0.06% 0.025µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1721461.689op/s 1725165.339op/s ± 1048.364op/s 1725100.493op/s ± 674.816op/s 1725799.106op/s 1726890.526op/s 1727759.473op/s 1728706.149op/s 0.21% 0.161 0.910 0.06% 74.131op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 464.352µs 464.950µs ± 0.309µs 464.919µs ± 0.204µs 465.121µs 465.500µs 465.859µs 465.948µs 0.22% 0.714 0.587 0.07% 0.022µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2146161.990op/s 2150769.748op/s ± 1429.874op/s 2150911.457op/s ± 944.262op/s 2151848.228op/s 2152641.388op/s 2153408.075op/s 2153536.742op/s 0.12% -0.710 0.578 0.07% 101.107op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 184.065µs 184.443µs ± 0.154µs 184.459µs ± 0.099µs 184.554µs 184.664µs 184.755µs 184.855µs 0.21% -0.341 -0.105 0.08% 0.011µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5409635.887op/s 5421746.997op/s ± 4534.660op/s 5421266.272op/s ± 2919.805op/s 5424400.888op/s 5430693.392op/s 5432424.833op/s 5432875.197op/s 0.21% 0.346 -0.104 0.08% 320.649op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 46.586µs 46.784µs ± 0.068µs 46.783µs ± 0.048µs 46.831µs 46.890µs 46.914µs 46.953µs 0.36% -0.133 -0.369 0.14% 0.005µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 21297822.864op/s 21374898.167op/s ± 30997.314op/s 21375318.299op/s ± 21716.511op/s 21396658.541op/s 21423015.311op/s 21439619.905op/s 21465597.954op/s 0.42% 0.140 -0.364 0.14% 2191.841op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 44.184µs 44.607µs ± 0.173µs 44.612µs ± 0.102µs 44.705µs 44.859µs 44.947µs 45.659µs 2.35% 0.923 5.884 0.39% 0.012µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21901503.100op/s 22418200.323op/s ± 86440.914op/s 22415415.430op/s ± 51166.415op/s 22474903.975op/s 22554659.253op/s 22610932.126op/s 22632797.942op/s 0.97% -0.843 5.410 0.38% 6112.296op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [579.606µs; 579.704µs] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1725020.046op/s; 1725310.632op/s] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [464.907µs; 464.993µs] or [-0.009%; +0.009%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2150571.581op/s; 2150967.914op/s] or [-0.009%; +0.009%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [184.421µs; 184.464µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5421118.537op/s; 5422375.457op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [46.775µs; 46.793µs] or [-0.020%; +0.020%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [21370602.238op/s; 21379194.097op/s] or [-0.020%; +0.020%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [44.583µs; 44.631µs] or [-0.054%; +0.054%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [22406220.444op/s; 22430180.202op/s] or [-0.053%; +0.053%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b960b4d 1725980166 gleocadie/fix-missing-symbol-for-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 36.260µs 36.894µs ± 0.990µs 36.444µs ± 0.116µs 36.599µs 38.995µs 39.044µs 40.307µs 10.60% 1.704 1.121 2.68% 0.070µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [36.756µs; 37.031µs] or [-0.372%; +0.372%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b960b4d 1725980166 gleocadie/fix-missing-symbol-for-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 1.170µs 1.342µs ± 0.058µs 1.361µs ± 0.037µs 1.388µs 1.419µs 1.432µs 1.434µs 5.34% -0.675 -0.011 4.28% 0.004µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [1.334µs; 1.350µs] or [-0.594%; +0.594%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.15%. Comparing base (9705ec2) to head (b960b4d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
+ Coverage   73.13%   73.15%   +0.01%     
==========================================
  Files         252      252              
  Lines       35959    35959              
==========================================
+ Hits        26300    26307       +7     
+ Misses       9659     9652       -7     
Components Coverage Δ
crashtracker 20.53% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 90.12% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 83.08% <ø> (ø)
ddcommon-ffi 69.52% <ø> (ø)
ddtelemetry 59.10% <ø> (ø)
ipc 83.63% <ø> (ø)
profiling 84.26% <ø> (ø)
profiling-ffi 77.42% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 40.12% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 91.66% <ø> (ø)
trace-mini-agent 70.88% <ø> (ø)
trace-normalization 98.25% <ø> (ø)
trace-obfuscation 95.73% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 92.86% <ø> (ø)

@gleocadie gleocadie force-pushed the gleocadie/fix-missing-symbol-for-crashtracker branch from 519b0ac to 65ab3ff Compare September 6, 2024 17:44
@gleocadie gleocadie force-pushed the gleocadie/fix-missing-symbol-for-crashtracker branch from b9d88d1 to 43957c6 Compare September 6, 2024 19:04
@github-actions github-actions bot added the profiling Relates to the profiling* modules. label Sep 6, 2024
@gleocadie gleocadie force-pushed the gleocadie/fix-missing-symbol-for-crashtracker branch 3 times, most recently from 172ceba to f265238 Compare September 6, 2024 19:10
@github-actions github-actions bot removed the ci-build label Sep 6, 2024
@gleocadie gleocadie force-pushed the gleocadie/fix-missing-symbol-for-crashtracker branch 2 times, most recently from a01e10b to 100921d Compare September 6, 2024 22:17
@github-actions github-actions bot removed the profiling Relates to the profiling* modules. label Sep 6, 2024
@gleocadie gleocadie force-pushed the gleocadie/fix-missing-symbol-for-crashtracker branch 2 times, most recently from c4e5183 to 061205f Compare September 6, 2024 22:19
@github-actions github-actions bot added the profiling Relates to the profiling* modules. label Sep 6, 2024
@gleocadie gleocadie added the bug Something isn't working label Sep 6, 2024
@gleocadie gleocadie changed the title check if ddog_crasht_demangle can be linked against Fix missing symbol ddog_crasht_demangle Sep 6, 2024
@gleocadie gleocadie force-pushed the gleocadie/fix-missing-symbol-for-crashtracker branch from 061205f to 2d9e34e Compare September 6, 2024 23:46
@gleocadie gleocadie marked this pull request as ready for review September 6, 2024 23:51
@gleocadie gleocadie requested review from a team as code owners September 6, 2024 23:51
@@ -8,7 +8,7 @@ license.workspace = true

[features]
default = []
crashtracker = ["datadog-profiling-ffi?/crashtracker-receiver", "datadog-profiling-ffi?/crashtracker-collector"]
crashtracker = ["datadog-profiling-ffi?/crashtracker-receiver", "datadog-profiling-ffi?/crashtracker-collector", "datadog-profiling-ffi?/demangler"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whether this also has to be crashtracker-demangler instead of just demangler.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed what's in the profiling-ffi/Cargo.toml

@taegyunkim
Copy link
Contributor

Do you plan to cut a new release for this?

@gleocadie
Copy link
Contributor Author

Do you plan to cut a new release for this?

this one and the next I'll be about to push yes.

Copy link
Contributor

@r1viollet r1viollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@morrisonlevi morrisonlevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone from .NET says it works now, then this looks good to me.

@gleocadie gleocadie force-pushed the gleocadie/fix-missing-symbol-for-crashtracker branch from 2d9e34e to b960b4d Compare September 10, 2024 14:56
@gleocadie gleocadie merged commit 54ed2cf into main Sep 11, 2024
30 checks passed
@gleocadie gleocadie deleted the gleocadie/fix-missing-symbol-for-crashtracker branch September 11, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working profiling Relates to the profiling* modules.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants