-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing symbol ddog_crasht_demangle
#611
Fix missing symbol ddog_crasht_demangle
#611
Conversation
BenchmarksComparisonBenchmark execution time: 2024-09-10 15:06:20 Comparing candidate commit b960b4d in PR branch Found 1 performance improvements and 1 performance regressions! Performance is the same for 49 metrics, 2 unstable metrics. scenario:redis/obfuscate_redis_string
scenario:tags/replace_trace_tags
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
BaselineOmitted due to size. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #611 +/- ##
==========================================
+ Coverage 73.13% 73.15% +0.01%
==========================================
Files 252 252
Lines 35959 35959
==========================================
+ Hits 26300 26307 +7
+ Misses 9659 9652 -7
|
519b0ac
to
65ab3ff
Compare
b9d88d1
to
43957c6
Compare
172ceba
to
f265238
Compare
a01e10b
to
100921d
Compare
c4e5183
to
061205f
Compare
ddog_crasht_demangle
061205f
to
2d9e34e
Compare
@@ -8,7 +8,7 @@ license.workspace = true | |||
|
|||
[features] | |||
default = [] | |||
crashtracker = ["datadog-profiling-ffi?/crashtracker-receiver", "datadog-profiling-ffi?/crashtracker-collector"] | |||
crashtracker = ["datadog-profiling-ffi?/crashtracker-receiver", "datadog-profiling-ffi?/crashtracker-collector", "datadog-profiling-ffi?/demangler"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure whether this also has to be crashtracker-demangler instead of just demangler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed what's in the profiling-ffi/Cargo.toml
Do you plan to cut a new release for this? |
this one and the next I'll be about to push yes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If someone from .NET says it works now, then this looks good to me.
2d9e34e
to
b960b4d
Compare
What does this PR do?
Ensure
ddog_crasht_demangle
is exported. Currently, it's not compiling/linking at all.Motivation
Since #551,
ddog_crasht_demangle
is not exported anymore (not in v11 nor v12).Additional Notes
How to test the change?
Added a call to
ddog_crasht_demangle
in the example.+
Downloaded the artifacts and checked that the symbol is part of the library
Next step
Add a test to check the exported functions.