Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cargo.toml default-members since builder has no default feature #644

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

bantonsson
Copy link
Contributor

What does this PR do?

Removes the default-members section of the Cargo.toml that was added to avoid the builder doing work, but now that builder doesn't have a default feature it probably doesn't add that much overhead.

Motivation

It's easy to miss adding a new crate in both places and then the crate is not included in workspace level commands.

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@pr-commenter
Copy link

pr-commenter bot commented Sep 20, 2024

Benchmarks

Comparison

Benchmark execution time: 2024-09-20 15:27:17

Comparing candidate commit 97f4b8c in PR branch ban/remove-default-members with baseline commit 09d1ef5 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 50 metrics, 2 unstable metrics.

scenario:redis/obfuscate_redis_string

  • 🟥 execution_time [+2.032µs; +2.459µs] or [+5.195%; +6.285%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 97f4b8c 1726845413 ban/remove-default-members
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 537.606µs 538.111µs ± 0.303µs 538.094µs ± 0.170µs 538.259µs 538.565µs 538.889µs 540.384µs 0.43% 2.286 14.788 0.06% 0.021µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1850535.311op/s 1858353.941op/s ± 1044.177op/s 1858412.473op/s ± 585.809op/s 1859001.667op/s 1859921.297op/s 1860023.315op/s 1860096.659op/s 0.09% -2.267 14.611 0.06% 73.834op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 466.827µs 467.384µs ± 0.255µs 467.360µs ± 0.165µs 467.542µs 467.783µs 468.019µs 468.264µs 0.19% 0.432 0.477 0.05% 0.018µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2135547.469op/s 2139566.821op/s ± 1166.049op/s 2139678.915op/s ± 754.659op/s 2140347.244op/s 2141336.987op/s 2141817.176op/s 2142121.413op/s 0.11% -0.428 0.470 0.05% 82.452op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 184.562µs 184.986µs ± 0.182µs 184.977µs ± 0.107µs 185.081µs 185.289µs 185.562µs 185.692µs 0.39% 0.683 1.499 0.10% 0.013µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5385259.441op/s 5405821.878op/s ± 5320.597op/s 5406069.475op/s ± 3131.533op/s 5409412.757op/s 5413756.271op/s 5417165.530op/s 5418242.980op/s 0.23% -0.674 1.476 0.10% 376.223op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 44.668µs 44.767µs ± 0.051µs 44.764µs ± 0.031µs 44.796µs 44.841µs 44.886µs 45.087µs 0.72% 1.393 6.627 0.11% 0.004µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 22179469.442op/s 22338002.193op/s ± 25519.665op/s 22339465.360op/s ± 15605.388op/s 22354712.543op/s 22375620.401op/s 22381729.067op/s 22387307.305op/s 0.21% -1.370 6.469 0.11% 1804.513op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 49.759µs 49.840µs ± 0.128µs 49.825µs ± 0.056µs 49.882µs 49.955µs 49.998µs 51.369µs 3.10% 8.760 101.680 0.26% 0.009µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 19466967.273op/s 20064417.623op/s ± 50227.376op/s 20070344.229op/s ± 22370.717op/s 20092179.884op/s 20095092.079op/s 20096176.609op/s 20096754.187op/s 0.13% -8.555 98.344 0.25% 3551.612op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [538.069µs; 538.153µs] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1858209.228op/s; 1858498.654op/s] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [467.349µs; 467.420µs] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2139405.218op/s; 2139728.424op/s] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [184.961µs; 185.011µs] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5405084.494op/s; 5406559.261op/s] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [44.760µs; 44.774µs] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [22334465.413op/s; 22341538.973op/s] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [49.822µs; 49.857µs] or [-0.035%; +0.035%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20057456.592op/s; 20071378.654op/s] or [-0.035%; +0.035%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 97f4b8c 1726845413 ban/remove-default-members
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 1.133µs 1.197µs ± 0.022µs 1.204µs ± 0.011µs 1.213µs 1.217µs 1.219µs 1.219µs 1.31% -1.432 1.230 1.87% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [1.194µs; 1.200µs] or [-0.260%; +0.260%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 97f4b8c 1726845413 ban/remove-default-members
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 9.009ms 9.036ms ± 0.012ms 9.035ms ± 0.009ms 9.044ms 9.056ms 9.066ms 9.075ms 0.45% 0.388 0.008 0.14% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [9.034ms; 9.037ms] or [-0.019%; +0.019%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 97f4b8c 1726845413 ban/remove-default-members
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 301.087ns 312.253ns ± 13.809ns 305.652ns ± 2.539ns 315.203ns 338.530ns 357.546ns 360.270ns 17.87% 1.839 2.602 4.41% 0.976ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [310.340ns; 314.167ns] or [-0.613%; +0.613%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 97f4b8c 1726845413 ban/remove-default-members
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 73.761µs 74.181µs ± 0.212µs 74.269µs ± 0.037µs 74.298µs 74.339µs 74.407µs 75.521µs 1.69% 0.561 6.679 0.29% 0.015µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [74.152µs; 74.211µs] or [-0.040%; +0.040%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 97f4b8c 1726845413 ban/remove-default-members
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 2.415µs 2.416µs ± 0.001µs 2.416µs ± 0.001µs 2.417µs 2.418µs 2.419µs 2.419µs 0.13% 0.886 0.119 0.04% 0.000µs 1 200
credit_card/is_card_number/ throughput 413342223.487op/s 413842545.825op/s ± 151736.798op/s 413872800.300op/s ± 101416.580op/s 413963753.712op/s 414019270.823op/s 414034345.511op/s 414045238.995op/s 0.04% -0.885 0.115 0.04% 10729.412op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 111.877µs 115.507µs ± 1.214µs 115.596µs ± 0.860µs 116.466µs 117.166µs 117.834µs 118.663µs 2.65% -0.374 0.097 1.05% 0.086µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 8427257.704op/s 8658421.431op/s ± 91384.725op/s 8650844.174op/s ± 64531.063op/s 8714558.341op/s 8823699.442op/s 8908504.620op/s 8938374.837op/s 3.32% 0.437 0.171 1.05% 6461.876op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 104.249µs 107.323µs ± 1.443µs 107.316µs ± 1.038µs 108.364µs 109.521µs 110.497µs 112.158µs 4.51% 0.176 -0.279 1.34% 0.102µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 8916018.298op/s 9319360.122op/s ± 125048.411op/s 9318284.749op/s ± 89739.974op/s 9405453.950op/s 9511081.622op/s 9579758.151op/s 9592378.577op/s 2.94% -0.109 -0.359 1.34% 8842.258op/s 1 200
credit_card/is_card_number/37828224631 execution_time 2.415µs 2.417µs ± 0.002µs 2.416µs ± 0.001µs 2.417µs 2.418µs 2.419µs 2.444µs 1.14% 10.544 132.026 0.09% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 409207454.437op/s 413818051.275op/s ± 361314.310op/s 413866994.108op/s ± 109388.788op/s 413963243.235op/s 414034931.915op/s 414054780.302op/s 414065046.327op/s 0.05% -10.483 130.987 0.09% 25548.780op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 101.264µs 105.727µs ± 1.435µs 105.942µs ± 1.010µs 106.899µs 107.694µs 108.086µs 108.145µs 2.08% -0.610 0.020 1.35% 0.101µs 1 200
credit_card/is_card_number/378282246310005 throughput 9246842.733op/s 9460099.872op/s ± 129543.394op/s 9439130.784op/s ± 90447.093op/s 9537606.664op/s 9695997.708op/s 9801275.721op/s 9875199.086op/s 4.62% 0.679 0.168 1.37% 9160.101op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 105.194µs 106.560µs ± 0.439µs 106.609µs ± 0.246µs 106.852µs 107.154µs 107.684µs 107.820µs 1.14% -0.336 0.818 0.41% 0.031µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 9274750.980op/s 9384521.654op/s ± 38681.147op/s 9380109.949op/s ± 21608.686op/s 9403196.383op/s 9449548.636op/s 9487907.524op/s 9506248.487op/s 1.34% 0.370 0.830 0.41% 2735.170op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 21.727µs 22.706µs ± 0.382µs 22.742µs ± 0.281µs 23.015µs 23.252µs 23.451µs 23.626µs 3.89% -0.255 -0.510 1.68% 0.027µs 1 200
credit_card/is_card_number/x371413321323331 throughput 42325712.472op/s 44052878.061op/s ± 745046.629op/s 43971384.547op/s ± 541421.884op/s 44580533.024op/s 45401196.739op/s 45825874.681op/s 46025293.643op/s 4.67% 0.327 -0.463 1.69% 52682.752op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 2.415µs 2.417µs ± 0.003µs 2.417µs ± 0.001µs 2.417µs 2.418µs 2.423µs 2.454µs 1.56% 11.150 139.898 0.12% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 407447538.545op/s 413780999.823op/s ± 489835.851op/s 413809230.958op/s ± 96377.465op/s 413952333.924op/s 414005519.657op/s 414040334.417op/s 414043590.317op/s 0.06% -11.086 138.721 0.12% 34636.625op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 86.959µs 87.319µs ± 0.289µs 87.271µs ± 0.073µs 87.331µs 87.864µs 88.310µs 89.677µs 2.76% 4.067 23.947 0.33% 0.020µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 11151082.625op/s 11452357.262op/s ± 37416.317op/s 11458532.716op/s ± 9528.239op/s 11470235.887op/s 11484204.682op/s 11490982.618op/s 11499717.107op/s 0.36% -3.977 22.875 0.33% 2645.733op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 79.642µs 80.185µs ± 0.579µs 80.059µs ± 0.217µs 80.294µs 80.979µs 82.781µs 83.959µs 4.87% 3.404 14.828 0.72% 0.041µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 11910569.725op/s 12471714.096op/s ± 87875.281op/s 12490761.214op/s ± 33888.552op/s 12523427.264op/s 12546700.072op/s 12554204.902op/s 12556130.928op/s 0.52% -3.293 13.952 0.70% 6213.721op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 2.415µs 2.416µs ± 0.001µs 2.416µs ± 0.001µs 2.417µs 2.418µs 2.418µs 2.421µs 0.19% 1.082 2.001 0.04% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 413091836.664op/s 413850171.205op/s ± 152621.022op/s 413885550.168op/s ± 98543.080op/s 413967387.713op/s 414032290.747op/s 414062815.214op/s 414106231.558op/s 0.05% -1.079 1.984 0.04% 10791.936op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 76.616µs 77.077µs ± 0.525µs 76.924µs ± 0.105µs 77.081µs 78.793µs 79.095µs 79.376µs 3.19% 2.981 8.403 0.68% 0.037µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 12598205.434op/s 12974574.235op/s ± 86632.025op/s 12999858.960op/s ± 17807.317op/s 13014624.878op/s 13033594.243op/s 13048462.514op/s 13052139.381op/s 0.40% -2.950 8.244 0.67% 6125.809op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 105.358µs 106.615µs ± 0.400µs 106.621µs ± 0.246µs 106.867µs 107.145µs 107.407µs 108.788µs 2.03% 0.381 3.775 0.37% 0.028µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 9192209.192op/s 9379645.852op/s ± 35155.130op/s 9379005.097op/s ± 21626.549op/s 9400532.100op/s 9436999.606op/s 9463266.145op/s 9491477.915op/s 1.20% -0.319 3.521 0.37% 2485.843op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 21.761µs 22.443µs ± 0.382µs 22.404µs ± 0.283µs 22.685µs 23.158µs 23.272µs 23.401µs 4.45% 0.450 -0.644 1.70% 0.027µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 42732398.506op/s 44569865.894op/s ± 752678.756op/s 44635264.097op/s ± 567736.964op/s 45204655.798op/s 45643300.571op/s 45872265.932op/s 45954539.731op/s 2.96% -0.392 -0.704 1.68% 53222.425op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [2.416µs; 2.417µs] or [-0.005%; +0.005%] None None None
credit_card/is_card_number/ throughput [413821516.564op/s; 413863575.085op/s] or [-0.005%; +0.005%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [115.339µs; 115.675µs] or [-0.146%; +0.146%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [8645756.387op/s; 8671086.475op/s] or [-0.146%; +0.146%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [107.123µs; 107.523µs] or [-0.186%; +0.186%] None None None
credit_card/is_card_number/ 378282246310005 throughput [9302029.615op/s; 9336690.629op/s] or [-0.186%; +0.186%] None None None
credit_card/is_card_number/37828224631 execution_time [2.416µs; 2.417µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/37828224631 throughput [413767976.587op/s; 413868125.964op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/378282246310005 execution_time [105.528µs; 105.926µs] or [-0.188%; +0.188%] None None None
credit_card/is_card_number/378282246310005 throughput [9442146.403op/s; 9478053.340op/s] or [-0.190%; +0.190%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [106.499µs; 106.621µs] or [-0.057%; +0.057%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [9379160.819op/s; 9389882.489op/s] or [-0.057%; +0.057%] None None None
credit_card/is_card_number/x371413321323331 execution_time [22.653µs; 22.759µs] or [-0.233%; +0.233%] None None None
credit_card/is_card_number/x371413321323331 throughput [43949621.763op/s; 44156134.358op/s] or [-0.234%; +0.234%] None None None
credit_card/is_card_number_no_luhn/ execution_time [2.416µs; 2.417µs] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/ throughput [413713113.285op/s; 413848886.361op/s] or [-0.016%; +0.016%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [87.279µs; 87.359µs] or [-0.046%; +0.046%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [11447171.720op/s; 11457542.804op/s] or [-0.045%; +0.045%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [80.105µs; 80.266µs] or [-0.100%; +0.100%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [12459535.428op/s; 12483892.765op/s] or [-0.098%; +0.098%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [2.416µs; 2.416µs] or [-0.005%; +0.005%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [413829019.399op/s; 413871323.010op/s] or [-0.005%; +0.005%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [77.005µs; 77.150µs] or [-0.094%; +0.094%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [12962567.870op/s; 12986580.601op/s] or [-0.093%; +0.093%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [106.560µs; 106.671µs] or [-0.052%; +0.052%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [9374773.689op/s; 9384518.015op/s] or [-0.052%; +0.052%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [22.390µs; 22.496µs] or [-0.236%; +0.236%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [44465551.857op/s; 44674179.930op/s] or [-0.234%; +0.234%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 97f4b8c 1726845413 ban/remove-default-members
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.894µs 24.305µs ± 10.985µs 19.408µs ± 0.288µs 20.482µs 43.983µs 46.758µs 101.052µs 420.69% 3.728 20.268 45.09% 0.777µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [22.782µs; 25.827µs] or [-6.264%; +6.264%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 97f4b8c 1726845413 ban/remove-default-members
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.692µs 2.759µs ± 0.029µs 2.767µs ± 0.009µs 2.775µs 2.807µs 2.812µs 2.823µs 2.02% -0.610 0.022 1.03% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.755µs; 2.763µs] or [-0.144%; +0.144%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 97f4b8c 1726845413 ban/remove-default-members
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 144.198µs 145.540µs ± 0.713µs 145.470µs ± 0.181µs 145.658µs 146.117µs 146.995µs 152.972µs 5.16% 6.949 64.903 0.49% 0.050µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [145.441µs; 145.639µs] or [-0.068%; +0.068%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 97f4b8c 1726845413 ban/remove-default-members
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.408µs 3.216µs ± 1.397µs 3.086µs ± 0.031µs 3.113µs 3.211µs 13.889µs 15.099µs 389.26% 7.654 58.827 43.32% 0.099µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.022µs; 3.410µs] or [-6.019%; +6.019%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 97f4b8c 1726845413 ban/remove-default-members
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 40.761µs 41.366µs ± 1.097µs 40.863µs ± 0.049µs 40.930µs 43.735µs 43.747µs 44.306µs 8.43% 1.698 0.926 2.64% 0.078µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [41.214µs; 41.518µs] or [-0.367%; +0.367%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 97f4b8c 1726845413 ban/remove-default-members
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 275.797µs 276.239µs ± 0.149µs 276.224µs ± 0.108µs 276.341µs 276.476µs 276.621µs 276.720µs 0.18% 0.306 0.247 0.05% 0.011µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3613759.852op/s 3620053.222op/s ± 1950.926op/s 3620249.554op/s ± 1418.756op/s 3621263.083op/s 3622913.179op/s 3623751.939op/s 3625850.262op/s 0.15% -0.303 0.243 0.05% 137.951op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 28.008µs 28.109µs ± 0.039µs 28.114µs ± 0.039µs 28.124µs 28.171µs 28.183µs 28.322µs 0.74% 1.371 5.138 0.14% 0.003µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 35307653.579op/s 35576250.859op/s ± 48816.144op/s 35569083.968op/s ± 49299.981op/s 35620155.905op/s 35622236.729op/s 35639505.053op/s 35703557.482op/s 0.38% -1.350 5.012 0.14% 3451.823op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 16.509µs 16.544µs ± 0.028µs 16.525µs ± 0.003µs 16.563µs 16.592µs 16.642µs 16.662µs 0.83% 1.359 2.225 0.17% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 60017964.699op/s 60443853.099op/s ± 101394.247op/s 60514791.123op/s ± 12475.399op/s 60521246.933op/s 60525981.034op/s 60553264.569op/s 60574264.562op/s 0.10% -1.347 2.168 0.17% 7169.656op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [276.218µs; 276.260µs] or [-0.007%; +0.007%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3619782.843op/s; 3620323.602op/s] or [-0.007%; +0.007%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [28.103µs; 28.114µs] or [-0.019%; +0.019%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [35569485.411op/s; 35583016.307op/s] or [-0.019%; +0.019%] None None None
normalization/normalize_name/normalize_name/good execution_time [16.540µs; 16.548µs] or [-0.023%; +0.023%] None None None
normalization/normalize_name/normalize_name/good throughput [60429800.832op/s; 60457905.367op/s] or [-0.023%; +0.023%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.62%. Comparing base (09d1ef5) to head (97f4b8c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #644      +/-   ##
==========================================
+ Coverage   73.58%   73.62%   +0.04%     
==========================================
  Files         255      255              
  Lines       36941    36941              
==========================================
+ Hits        27182    27197      +15     
+ Misses       9759     9744      -15     
Components Coverage Δ
crashtracker 20.53% <ø> (+0.05%) ⬆️
datadog-alloc 98.73% <ø> (ø)
data-pipeline 91.65% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 83.08% <ø> (ø)
ddcommon-ffi 69.52% <ø> (ø)
ddtelemetry 59.10% <ø> (ø)
ipc 83.58% <ø> (ø)
profiling 84.26% <ø> (ø)
profiling-ffi 77.42% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 40.10% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 94.77% <ø> (ø)
trace-mini-agent 72.47% <ø> (ø)
trace-normalization 98.25% <ø> (ø)
trace-obfuscation 95.73% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.41% <ø> (ø)

@taegyunkim taegyunkim merged commit 13eac56 into main Sep 20, 2024
30 checks passed
@taegyunkim taegyunkim deleted the ban/remove-default-members branch September 20, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants