-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PROF-10680] Use ELF virtual address instead of file offset #680
Conversation
ecbe4f6
to
1d8f916
Compare
BenchmarksComparisonBenchmark execution time: 2024-10-17 11:18:46 Comparing candidate commit 3c0e636 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
BaselineOmitted due to size. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1d8f916
to
248e8bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
When computing normalized address, use elf virtual addresses instead of file offsets because file offset alone is not enough to perform symbolization with split debug information.
248e8bd
to
3c0e636
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #680 +/- ##
==========================================
- Coverage 71.81% 71.80% -0.02%
==========================================
Files 271 271
Lines 40979 40987 +8
==========================================
+ Hits 29428 29429 +1
- Misses 11551 11558 +7
|
What does this PR do?
Use ELF virtual address instead of file offset for normarlized addresses.
Motivation
When computing normalized address, use elf virtual addresses instead of file offsets because file offset alone is not enough to perform symbolization with split debug information.
Additional Notes
file_offset
should probably be renamed, this will be addressed in a later PR.