Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve clippy warnings #684

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Resolve clippy warnings #684

merged 1 commit into from
Oct 21, 2024

Conversation

danielsn
Copy link
Contributor

What does this PR do?

Implements some small changes proposed by clippy.

Motivation

We should be clippy clean.

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Existing tests should be sufficient.

@danielsn danielsn requested review from a team as code owners October 21, 2024 17:28
@pr-commenter
Copy link

pr-commenter bot commented Oct 21, 2024

Benchmarks

Comparison

Benchmark execution time: 2024-10-21 17:37:35

Comparing candidate commit cef9d63 in PR branch dsn/clippy with baseline commit a76c5ad in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz cef9d63 1729531609 dsn/clippy
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 142.305µs 143.122µs ± 0.420µs 143.059µs ± 0.172µs 143.265µs 143.811µs 144.643µs 146.100µs 2.13% 2.585 13.816 0.29% 0.030µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [143.064µs; 143.180µs] or [-0.041%; +0.041%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz cef9d63 1729531609 dsn/clippy
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 191.260µs 193.208µs ± 0.749µs 193.263µs ± 0.497µs 193.710µs 194.437µs 194.783µs 195.064µs 0.93% -0.033 -0.278 0.39% 0.053µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 5126526.727op/s 5175852.590op/s ± 20077.891op/s 5174308.497op/s ± 13319.127op/s 5188904.102op/s 5209759.948op/s 5220809.094op/s 5228493.418op/s 1.05% 0.053 -0.276 0.39% 1419.721op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.188µs 18.225µs ± 0.036µs 18.207µs ± 0.011µs 18.244µs 18.295µs 18.340µs 18.352µs 0.80% 1.284 1.020 0.19% 0.003µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 54490024.170op/s 54868428.014op/s ± 106766.463op/s 54923904.792op/s ± 33714.968op/s 54948106.055op/s 54966738.602op/s 54973176.608op/s 54981895.580op/s 0.11% -1.276 0.988 0.19% 7549.529op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 11.297µs 11.335µs ± 0.024µs 11.330µs ± 0.016µs 11.351µs 11.374µs 11.403µs 11.464µs 1.19% 1.276 3.495 0.21% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 87226226.289op/s 88220547.533op/s ± 184323.595op/s 88262551.685op/s ± 122200.235op/s 88351398.856op/s 88440361.437op/s 88504731.095op/s 88521627.069op/s 0.29% -1.252 3.349 0.21% 13033.646op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [193.104µs; 193.312µs] or [-0.054%; +0.054%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [5173069.987op/s; 5178635.192op/s] or [-0.054%; +0.054%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.221µs; 18.230µs] or [-0.027%; +0.027%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [54853631.209op/s; 54883224.819op/s] or [-0.027%; +0.027%] None None None
normalization/normalize_name/normalize_name/good execution_time [11.332µs; 11.339µs] or [-0.029%; +0.029%] None None None
normalization/normalize_name/normalize_name/good throughput [88195002.056op/s; 88246093.011op/s] or [-0.029%; +0.029%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz cef9d63 1729531609 dsn/clippy
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 258.576ns 273.287ns ± 18.905ns 264.962ns ± 4.271ns 280.581ns 316.039ns 332.278ns 334.534ns 26.26% 1.605 1.563 6.90% 1.337ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [270.667ns; 275.907ns] or [-0.959%; +0.959%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz cef9d63 1729531609 dsn/clippy
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 1.130µs 1.187µs ± 0.018µs 1.192µs ± 0.008µs 1.199µs 1.204µs 1.206µs 1.207µs 1.28% -1.596 1.817 1.52% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [1.184µs; 1.189µs] or [-0.212%; +0.212%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz cef9d63 1729531609 dsn/clippy
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 9.085ms 9.130ms ± 0.023ms 9.129ms ± 0.008ms 9.137ms 9.152ms 9.182ms 9.359ms 2.52% 5.601 53.255 0.25% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [9.127ms; 9.133ms] or [-0.034%; +0.034%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz cef9d63 1729531609 dsn/clippy
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 36.970µs 37.655µs ± 1.263µs 37.068µs ± 0.045µs 37.171µs 40.398µs 40.440µs 40.511µs 9.29% 1.703 0.915 3.35% 0.089µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [37.480µs; 37.830µs] or [-0.465%; +0.465%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz cef9d63 1729531609 dsn/clippy
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 72.202µs 72.363µs ± 0.136µs 72.346µs ± 0.028µs 72.376µs 72.423µs 72.683µs 74.088µs 2.41% 10.516 128.513 0.19% 0.010µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [72.344µs; 72.382µs] or [-0.026%; +0.026%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz cef9d63 1729531609 dsn/clippy
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.685µs 2.715µs ± 0.015µs 2.710µs ± 0.008µs 2.722µs 2.754µs 2.758µs 2.761µs 1.88% 1.184 1.146 0.57% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.713µs; 2.717µs] or [-0.079%; +0.079%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz cef9d63 1729531609 dsn/clippy
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.391µs 3.245µs ± 1.405µs 3.065µs ± 0.026µs 3.090µs 3.532µs 13.859µs 14.928µs 387.07% 7.508 56.908 43.18% 0.099µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.050µs; 3.440µs] or [-6.000%; +6.000%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz cef9d63 1729531609 dsn/clippy
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 622.725µs 624.273µs ± 0.519µs 624.340µs ± 0.361µs 624.657µs 625.001µs 625.303µs 625.462µs 0.18% -0.361 -0.284 0.08% 0.037µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1598817.241op/s 1601865.441op/s ± 1332.862op/s 1601691.753op/s ± 924.940op/s 1602905.105op/s 1603992.833op/s 1604989.297op/s 1605846.566op/s 0.26% 0.365 -0.280 0.08% 94.248op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 461.203µs 462.155µs ± 0.559µs 462.021µs ± 0.302µs 462.444µs 463.307µs 463.801µs 464.008µs 0.43% 1.095 0.914 0.12% 0.040µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2155137.456op/s 2163777.550op/s ± 2613.983op/s 2164403.783op/s ± 1414.453op/s 2165574.775op/s 2166831.508op/s 2167687.166op/s 2168244.597op/s 0.18% -1.088 0.897 0.12% 184.837op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 178.048µs 178.347µs ± 0.126µs 178.338µs ± 0.087µs 178.428µs 178.535µs 178.690µs 179.040µs 0.39% 1.158 4.330 0.07% 0.009µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5585356.992op/s 5607042.275op/s ± 3948.739op/s 5607316.865op/s ± 2745.819op/s 5609970.176op/s 5612509.369op/s 5614429.329op/s 5616471.439op/s 0.16% -1.148 4.273 0.07% 279.218op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 46.588µs 46.744µs ± 0.087µs 46.732µs ± 0.055µs 46.792µs 46.909µs 46.983µs 47.042µs 0.66% 0.802 0.509 0.19% 0.006µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 21257551.519op/s 21393164.098op/s ± 39885.735op/s 21398629.613op/s ± 25389.173op/s 21421224.567op/s 21446840.519op/s 21451818.223op/s 21464970.538op/s 0.31% -0.791 0.484 0.19% 2820.347op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 48.362µs 48.756µs ± 0.336µs 48.599µs ± 0.084µs 48.857µs 49.414µs 49.567µs 49.605µs 2.07% 1.120 -0.313 0.69% 0.024µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20159409.357op/s 20511174.411op/s ± 140121.548op/s 20576587.074op/s ± 35594.726op/s 20604932.054op/s 20641115.457op/s 20659984.204op/s 20677555.403op/s 0.49% -1.111 -0.333 0.68% 9908.090op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [624.201µs; 624.345µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1601680.719op/s; 1602050.163op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [462.078µs; 462.233µs] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2163415.277op/s; 2164139.823op/s] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [178.330µs; 178.365µs] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5606495.018op/s; 5607589.533op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [46.732µs; 46.756µs] or [-0.026%; +0.026%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [21387636.319op/s; 21398691.878op/s] or [-0.026%; +0.026%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [48.710µs; 48.803µs] or [-0.095%; +0.095%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20491754.912op/s; 20530593.910op/s] or [-0.095%; +0.095%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz cef9d63 1729531609 dsn/clippy
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.760µs 24.350µs ± 11.488µs 18.667µs ± 0.649µs 21.890µs 47.258µs 50.555µs 100.253µs 437.06% 2.596 10.006 47.06% 0.812µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [22.758µs; 25.942µs] or [-6.538%; +6.538%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz cef9d63 1729531609 dsn/clippy
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.600µs 4.616µs ± 0.003µs 4.616µs ± 0.002µs 4.618µs 4.620µs 4.623µs 4.624µs 0.17% -1.044 7.606 0.06% 0.000µs 1 200
credit_card/is_card_number/ throughput 216266429.063op/s 216618233.395op/s ± 121950.664op/s 216625437.525op/s ± 73356.399op/s 216684680.396op/s 216780079.651op/s 216909987.305op/s 217399548.266op/s 0.36% 1.058 7.697 0.06% 8623.214op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 118.667µs 120.773µs ± 0.752µs 120.678µs ± 0.521µs 121.381µs 122.054µs 122.311µs 122.478µs 1.49% 0.078 -0.498 0.62% 0.053µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 8164746.885op/s 8280345.620op/s ± 51547.873op/s 8286493.070op/s ± 35909.268op/s 8315438.654op/s 8358508.769op/s 8398733.571op/s 8426940.054op/s 1.69% -0.050 -0.483 0.62% 3644.985op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 111.691µs 112.841µs ± 0.638µs 112.716µs ± 0.389µs 113.216µs 113.978µs 114.492µs 115.010µs 2.04% 0.679 0.071 0.56% 0.045µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 8694901.193op/s 8862340.485op/s ± 49888.747op/s 8871881.017op/s ± 30649.529op/s 8900327.757op/s 8927465.743op/s 8946879.819op/s 8953294.485op/s 0.92% -0.652 0.017 0.56% 3527.667op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.599µs 4.618µs ± 0.013µs 4.616µs ± 0.002µs 4.618µs 4.621µs 4.642µs 4.786µs 3.67% 11.593 147.022 0.28% 0.001µs 1 200
credit_card/is_card_number/37828224631 throughput 208941359.600op/s 216563638.404op/s ± 583912.827op/s 216618486.464op/s ± 81775.415op/s 216699116.954op/s 216787678.693op/s 216829974.419op/s 217434908.246op/s 0.38% -11.472 144.682 0.27% 41288.872op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 107.352µs 109.068µs ± 0.667µs 109.032µs ± 0.476µs 109.572µs 110.107µs 110.807µs 111.067µs 1.87% 0.216 0.023 0.61% 0.047µs 1 200
credit_card/is_card_number/378282246310005 throughput 9003550.628op/s 9168947.041op/s ± 56041.486op/s 9171616.156op/s ± 40022.784op/s 9209079.745op/s 9256968.522op/s 9292879.138op/s 9315164.308op/s 1.57% -0.180 0.003 0.61% 3962.731op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 117.885µs 118.979µs ± 0.398µs 118.979µs ± 0.267µs 119.253µs 119.586µs 119.880µs 120.177µs 1.01% -0.073 0.172 0.33% 0.028µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 8321087.466op/s 8404954.596op/s ± 28137.790op/s 8404854.945op/s ± 18869.599op/s 8423140.319op/s 8451160.343op/s 8473594.298op/s 8482847.682op/s 0.93% 0.094 0.171 0.33% 1989.642op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 26.550µs 27.196µs ± 0.407µs 27.094µs ± 0.260µs 27.464µs 27.992µs 28.253µs 28.740µs 6.08% 0.881 0.422 1.49% 0.029µs 1 200
credit_card/is_card_number/x371413321323331 throughput 34794599.044op/s 36778566.741op/s ± 544017.645op/s 36908862.458op/s ± 353940.501op/s 37188942.570op/s 37485044.252op/s 37573303.200op/s 37664118.574op/s 2.05% -0.810 0.219 1.48% 38467.857op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.600µs 4.617µs ± 0.007µs 4.616µs ± 0.002µs 4.618µs 4.621µs 4.625µs 4.704µs 1.91% 10.418 131.240 0.15% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 212571562.653op/s 216599448.011op/s ± 316707.194op/s 216634283.994op/s ± 75528.470op/s 216696597.867op/s 216778264.550op/s 216836300.104op/s 217406091.504op/s 0.36% -10.308 129.438 0.15% 22394.580op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 103.644µs 104.833µs ± 0.466µs 104.892µs ± 0.302µs 105.146µs 105.579µs 105.710µs 105.822µs 0.89% -0.282 -0.374 0.44% 0.033µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 9449808.523op/s 9539137.978op/s ± 42416.479op/s 9533589.495op/s ± 27410.251op/s 9565132.709op/s 9611253.232op/s 9638231.821op/s 9648446.781op/s 1.20% 0.303 -0.360 0.44% 2999.298op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 94.543µs 96.342µs ± 0.696µs 96.300µs ± 0.458µs 96.775µs 97.542µs 97.927µs 98.667µs 2.46% 0.180 0.329 0.72% 0.049µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 10135051.510op/s 10380258.347op/s ± 74859.198op/s 10384208.803op/s ± 49200.502op/s 10427224.197op/s 10499784.518op/s 10561094.781op/s 10577228.874op/s 1.86% -0.131 0.306 0.72% 5293.345op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.602µs 4.618µs ± 0.016µs 4.616µs ± 0.002µs 4.618µs 4.621µs 4.624µs 4.834µs 4.71% 13.013 175.463 0.34% 0.001µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 206888280.806op/s 216568209.475op/s ± 707725.177op/s 216626553.233op/s ± 83287.397op/s 216710046.213op/s 216789640.733op/s 216861535.702op/s 217315323.631op/s 0.32% -12.930 173.864 0.33% 50043.727op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 90.456µs 92.524µs ± 0.888µs 92.382µs ± 0.645µs 93.179µs 94.097µs 94.621µs 95.248µs 3.10% 0.447 -0.368 0.96% 0.063µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 10498888.722op/s 10809005.419op/s ± 103299.024op/s 10824596.733op/s ± 75527.306op/s 10890991.649op/s 10953125.908op/s 10992732.326op/s 11055062.400op/s 2.13% -0.406 -0.419 0.95% 7304.344op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 117.486µs 119.038µs ± 0.425µs 119.082µs ± 0.282µs 119.367µs 119.626µs 119.886µs 119.982µs 0.76% -0.547 0.553 0.36% 0.030µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 8334573.714op/s 8400809.757op/s ± 30029.042op/s 8397580.600op/s ± 19867.345op/s 8417092.274op/s 8453233.170op/s 8478274.557op/s 8511671.204op/s 1.36% 0.571 0.602 0.36% 2123.374op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 26.626µs 27.401µs ± 0.452µs 27.375µs ± 0.346µs 27.743µs 28.175µs 28.395µs 28.548µs 4.28% 0.341 -0.650 1.65% 0.032µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 35028713.468op/s 36504843.558op/s ± 599089.588op/s 36529264.098op/s ± 464405.822op/s 36985205.252op/s 37407803.352op/s 37510363.701op/s 37557464.206op/s 2.81% -0.281 -0.699 1.64% 42362.031op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.616µs; 4.617µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/ throughput [216601332.205op/s; 216635134.584op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [120.668µs; 120.877µs] or [-0.086%; +0.086%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [8273201.581op/s; 8287489.659op/s] or [-0.086%; +0.086%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [112.752µs; 112.929µs] or [-0.078%; +0.078%] None None None
credit_card/is_card_number/ 378282246310005 throughput [8855426.384op/s; 8869254.585op/s] or [-0.078%; +0.078%] None None None
credit_card/is_card_number/37828224631 execution_time [4.616µs; 4.619µs] or [-0.039%; +0.039%] None None None
credit_card/is_card_number/37828224631 throughput [216482713.702op/s; 216644563.106op/s] or [-0.037%; +0.037%] None None None
credit_card/is_card_number/378282246310005 execution_time [108.975µs; 109.160µs] or [-0.085%; +0.085%] None None None
credit_card/is_card_number/378282246310005 throughput [9161180.230op/s; 9176713.852op/s] or [-0.085%; +0.085%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [118.924µs; 119.034µs] or [-0.046%; +0.046%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [8401054.969op/s; 8408854.223op/s] or [-0.046%; +0.046%] None None None
credit_card/is_card_number/x371413321323331 execution_time [27.139µs; 27.252µs] or [-0.208%; +0.208%] None None None
credit_card/is_card_number/x371413321323331 throughput [36703171.128op/s; 36853962.355op/s] or [-0.205%; +0.205%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.616µs; 4.618µs] or [-0.021%; +0.021%] None None None
credit_card/is_card_number_no_luhn/ throughput [216555555.440op/s; 216643340.582op/s] or [-0.020%; +0.020%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [104.769µs; 104.898µs] or [-0.062%; +0.062%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [9533259.462op/s; 9545016.494op/s] or [-0.062%; +0.062%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [96.245µs; 96.438µs] or [-0.100%; +0.100%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [10369883.582op/s; 10390633.112op/s] or [-0.100%; +0.100%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.615µs; 4.620µs] or [-0.047%; +0.047%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [216470125.572op/s; 216666293.378op/s] or [-0.045%; +0.045%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [92.401µs; 92.647µs] or [-0.133%; +0.133%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [10794689.168op/s; 10823321.670op/s] or [-0.132%; +0.132%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [118.979µs; 119.097µs] or [-0.049%; +0.049%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [8396648.021op/s; 8404971.494op/s] or [-0.050%; +0.050%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [27.338µs; 27.464µs] or [-0.229%; +0.229%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [36421815.502op/s; 36587871.613op/s] or [-0.227%; +0.227%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.80%. Comparing base (a76c5ad) to head (cef9d63).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #684      +/-   ##
==========================================
+ Coverage   71.77%   71.80%   +0.03%     
==========================================
  Files         271      271              
  Lines       40992    40992              
==========================================
+ Hits        29422    29435      +13     
+ Misses      11570    11557      -13     
Components Coverage Δ
crashtracker 20.28% <ø> (-0.06%) ⬇️
crashtracker-ffi 9.07% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 91.92% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 82.73% <ø> (ø)
ddcommon-ffi 69.12% <ø> (ø)
ddtelemetry 59.10% <ø> (ø)
ddtelemetry-ffi 22.13% <ø> (ø)
dogstatsd 88.86% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.65% <ø> (ø)
profiling 84.30% <ø> (ø)
profiling-ffi 77.46% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 36.09% <0.00%> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 94.77% <ø> (ø)
trace-mini-agent 72.45% <ø> (ø)
trace-normalization 98.25% <ø> (ø)
trace-obfuscation 95.73% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.08% <ø> (ø)

@danielsn danielsn merged commit 6e2d784 into main Oct 21, 2024
30 checks passed
@danielsn danielsn deleted the dsn/clippy branch October 21, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants