Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand detections per parameter #332

Merged
merged 4 commits into from
Aug 14, 2024
Merged

Conversation

Anilm3
Copy link
Collaborator

@Anilm3 Anilm3 commented Aug 13, 2024

This PR introduces an iterator to iterate through all possible matches of a parameter within a given resource. This expands the number of detections that one could perform on a single resource. This is now being used in SQLi, SHi and SSRF.

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.59%. Comparing base (9332b9d) to head (342a630).

Files Patch % Lines
src/condition/match_iterator.hpp 90.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
+ Coverage   84.51%   84.59%   +0.08%     
==========================================
  Files         144      145       +1     
  Lines        6948     6960      +12     
  Branches     3182     3183       +1     
==========================================
+ Hits         5872     5888      +16     
  Misses        400      400              
+ Partials      676      672       -4     
Flag Coverage Δ
waf_test 84.59% <91.66%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Anilm3 Anilm3 marked this pull request as ready for review August 13, 2024 15:28
@Anilm3 Anilm3 requested a review from a team as a code owner August 13, 2024 15:28
@pr-commenter
Copy link

pr-commenter bot commented Aug 13, 2024

Benchmarks

Benchmark execution time: 2024-08-13 16:15:02

Comparing candidate commit 342a630 in PR branch anilm3/expand-detections-per-param with baseline commit 9332b9d in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@Anilm3 Anilm3 merged commit 506c87d into master Aug 14, 2024
50 checks passed
@Anilm3 Anilm3 deleted the anilm3/expand-detections-per-param branch August 14, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants