feat: add log/slog instrumentation #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
=======================================
Coverage 64.76% 64.76%
=======================================
Files 76 76
Lines 3993 3993
=======================================
Hits 2586 2586
Misses 1134 1134
Partials 273 273
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Add instrumentation for log/slog. Implemented using dd-trace-go's log/slog.Handler wrapper to wrap any handler passed to log/slog.New. This commit does not instrument the default log/slog.Logger. We could do that, for example, by adding some logic like this to func main() if log/slog is imported by package main: slog.SetDefault( slog.New( slogtrace.WrapHandler( slog.Default().Handler(), ), ), ) Will leave that as a followup for now.
nsrip-dd
force-pushed
the
nick.ripley/slog
branch
from
5682ecc
to
18ed591
Compare
felixge
approved these changes
Aug 6, 2024
RomainMuller
approved these changes
Aug 6, 2024
RomainMuller
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add instrumentation for
log/slog. Implemented using dd-trace-go'slog/slog.Handlerwrapper to wrap any handler passed tolog/slog.New.This commit does not instrument the default
log/slog.Logger. We coulddo that, for example, by adding some logic like this to
func main()iflog/slogis imported by package main:Will leave that as a followup for now.
Motivation
I maintain an app that uses
log/slogfor logging. I'd like to eventuallyinstrument the app using Orchestrion, and having trace-log correlation is very
useful for debugging.
Reviewer's Checklist