fix: propagate --log-level and --log-file to child processes #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the log level is set via `--log-level`, set the corresponding environment variables so that the child processes will get it. This was done for `--log-file` already, but only if it was originally a relative path. Propagate it always. I noticed this when investigating #223. I was setting the log level to "trace" via the command line and didn't see much output. It took me a bit to realize that the setting wasn't picked up by all the workers. I set the env var instead, but ideally the command line argument works the same way :)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #224 +/- ##
==========================================
- Coverage 61.51% 61.50% -0.02%
==========================================
Files 90 90
Lines 4914 4915 +1
==========================================
Hits 3023 3023
- Misses 1568 1569 +1
Partials 323 323
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
RomainMuller
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If the log level is set via
--log-level, set the corresponding environmentvariables so that the child processes will get it. This was done for
--log-filealready, but only if it was originally a relative path. Propagateit always.
Motivation
I noticed this when investigating #223. I was setting the log level to "trace"
via the command line and didn't see much output. It took me a bit to realize
that the setting wasn't picked up by all the workers. I set the env var
instead, but ideally the command line argument works the
same way :)
Reviewer's Checklist