Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for aws-sdk-go-v2 #244

Merged
merged 13 commits into from
Aug 30, 2024

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Aug 26, 2024

  • Adds support for github.com/aws/aws-sdk-go-v2.
  • It also adds a new parameter for the struct-literal join-point match, which allows to limit the match by the struct literal style: value-only, pointer-only and any. This was required for the aws-sdk-go-v2 implementation.

@rarguelloF rarguelloF changed the title add support for aws-sdk-go-v2 feat: add support for aws-sdk-go-v2 Aug 26, 2024
@rarguelloF rarguelloF marked this pull request as ready for review August 29, 2024 17:50
@rarguelloF rarguelloF requested a review from a team as a code owner August 29, 2024 17:50
_integration-tests/tests/aws.v2/base.go Outdated Show resolved Hide resolved
_integration-tests/tests/aws.v2/base.go Outdated Show resolved Hide resolved
_integration-tests/tests/aws.v2/base.go Outdated Show resolved Hide resolved
docs/static/schema.json Outdated Show resolved Hide resolved
# Conflicts:
#	docs/static/schema.json
@RomainMuller RomainMuller added this pull request to the merge queue Aug 30, 2024
Merged via the queue into main with commit e070af5 Aug 30, 2024
22 checks passed
@RomainMuller RomainMuller deleted the rarguellof/APPSEC-53279/add-support-aws-sdk-v2 branch August 30, 2024 14:44
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 56.48148% with 47 lines in your changes missing coverage. Please review.

Project coverage is 62.53%. Comparing base (f109ee0) to head (2d5a31d).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/injector/aspect/join/struct.go 71.42% 22 Missing and 2 partials ⚠️
_integration-tests/utils/testcontainers.go 0.00% 22 Missing ⚠️
internal/injector/builtin/generator/schema.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
- Coverage   63.90%   62.53%   -1.38%     
==========================================
  Files         101      102       +1     
  Lines        5259     5359     +100     
==========================================
- Hits         3361     3351      -10     
- Misses       1538     1666     +128     
+ Partials      360      342      -18     
Components Coverage Δ
Instruments 34.56% <ø> (ø)
Go Driver 62.92% <ø> (ø)
Toolexec Driver 66.56% <ø> (ø)
Aspects 69.99% <71.42%> (+0.02%) ⬆️
Injector 71.62% <70.93%> (-0.04%) ⬇️
Files with missing lines Coverage Δ
internal/injector/builtin/generator/schema.go 69.91% <50.00%> (ø)
_integration-tests/utils/testcontainers.go 0.00% <0.00%> (ø)
internal/injector/aspect/join/struct.go 71.50% <71.42%> (-0.72%) ⬇️

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants