fix: case-based name conflict with DataDog
#288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Case-conflicting import paths cause issues when using `go mod vendor` as the layout on case-sensitive file systems is different from that on case-insensitive file system. This is a long-known issue with the Go toolchain, however fixing this is non-trivial and could have undesirable consequences. Since the capitalized form of `DataDog` (sic) is most common today, renaming the `orchestrion` module is the most pragramtic solution today. Caused-By golang/go#38342 Fixes #287
|
Should we do a v0.9.0 for this ? |
eliottness
approved these changes
Sep 23, 2024
RomainMuller
force-pushed
the
romain.marcadier/issue-287
branch
from
c72b146
to
69a5ea7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #288 +/- ##
=======================================
Coverage 73.48% 73.48%
=======================================
Files 144 144
Lines 7861 7861
=======================================
Hits 5777 5777
Misses 1655 1655
Partials 429 429
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Case-conflicting import paths cause issues when using
go mod vendoras the layout on case-sensitive file systems is different from that on case-insensitive file system. This is a long-known issue with the Go toolchain, however fixing this is non-trivial and could have undesirable consequences.Since the capitalized form of
DataDog(sic) is most common today, renaming theorchestrionmodule is the most pragramtic solution today.Caused-By golang/go#38342
Fixes #287