fix: pin pip for pip-tools<7 #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majorgreys
force-pushed
the
majorgreys/pin-pip
branch
from
f1db364
to
6b1b145
Compare
majorgreys
force-pushed
the
majorgreys/pin-pip
branch
2 times, most recently
from
be3b69e
to
54e1537
Compare
brettlangdon
approved these changes
Jul 21, 2023
emmettbutler
approved these changes
Jul 21, 2023
majorgreys
force-pushed
the
majorgreys/pin-pip
branch
2 times, most recently
from
7d3d1c7
to
6c8417b
Compare
majorgreys
force-pushed
the
majorgreys/pin-pip
branch
from
6c8417b
to
ca16c4b
Compare
16 tasks
Yun-Kim
added a commit
to DataDog/dd-trace-py
that referenced
this pull request
Jul 24, 2023
This PR upgrades riot to the recently released version 0.17.5, which involves pinning riot's pip dependency. This formerly broke our nightly 1.x latest CI runs, due to the issue with pip-tools and Python 3.7: DataDog/riot#214 We won't see any difference in our regular non-latest CI runs, but this should fix our failing nightly 1.x jobs. ## Checklist - [x] Change(s) are motivated and described in the PR description. - [x] Testing strategy is described if automated tests are not included in the PR. - [x] Risk is outlined (performance impact, potential for breakage, maintainability, etc). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed. If no release note is required, add label `changelog/no-changelog`. - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)). - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Title is accurate. - [x] No unnecessary changes are introduced. - [x] Description motivates each change. - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [x] Testing strategy adequately addresses listed risk(s). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] Release note makes sense to a user of the library. - [x] Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment. - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
romainkomorndatadog
pushed a commit
to DataDog/dd-trace-py
that referenced
this pull request
Aug 8, 2023
This PR upgrades riot to the recently released version 0.17.5, which involves pinning riot's pip dependency. This formerly broke our nightly 1.x latest CI runs, due to the issue with pip-tools and Python 3.7: DataDog/riot#214 We won't see any difference in our regular non-latest CI runs, but this should fix our failing nightly 1.x jobs. ## Checklist - [x] Change(s) are motivated and described in the PR description. - [x] Testing strategy is described if automated tests are not included in the PR. - [x] Risk is outlined (performance impact, potential for breakage, maintainability, etc). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed. If no release note is required, add label `changelog/no-changelog`. - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)). - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Title is accurate. - [x] No unnecessary changes are introduced. - [x] Description motivates each change. - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [x] Testing strategy adequately addresses listed risk(s). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] Release note makes sense to a user of the library. - [x] Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment. - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jazzband/pip-tools#1906 is resolved in pip-tools==7.0.0 which happens to also drop support for Python 3.7. This PR pins pip for Python 3.7.
Error:
https://github.com/DataDog/riot/actions/runs/5520208394/job/15245525172