add validation to query options

DataDog · Aug 13, 2019 · 6338ed2 · 6338ed2
1 parent 1eb55bc
commit 6338ed2
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/datadog/resource_datadog_service_level_objective.go b/datadog/resource_datadog_service_level_objective.go
@@ -97,13 +97,15 @@ func resourceDatadogServiceLevelObjective() *schema.Resource {
 							StateFunc: func(val interface{}) string {
 								return strings.TrimSpace(val.(string))
 							},
+							ValidateFunc: validQueryOption,
 						},
 						"denominator": {
 							Type:     schema.TypeString,
 							Required: true,
 							StateFunc: func(val interface{}) string {
 								return strings.TrimSpace(val.(string))
 							},
+							ValidateFunc: validQueryOption,
 						},
 					},
 				},
@@ -487,3 +489,13 @@ func suppressDataDogSLODisplayValueDiff(k, old, new string, d *schema.ResourceDa
 
 	return suppressDataDogFloatIntDiff(k, old, new, d)
 }
+
+// validQueryOption validates that the `query` parameter is naively valid.
+func validQueryOption(v interface{}, k string) (ws []string, errors []error) {
+	strVal := strings.TrimSpace(v.(string))
+	if strVal == "" {
+		errors = append(errors, fmt.Errorf("empty `query.%s` specified for SLO", k))
+		return
+	}
+	return
+}