[data_source_datadog_service_account] fix exact_match pointer bug #2572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @pablito-perez and the rest of your teammates on |
pablito-perez
force-pushed
the
pablo.perez/data-service-account-exact-match
branch
from
eba2742
to
2b42957
Compare
pablito-perez
changed the base branch from
master
to
pablo.perez/data-service-account-exact-match-test
pablito-perez
changed the title
pablito-perez
force-pushed
the
pablo.perez/data-service-account-exact-match-test
branch
from
f69b899
to
27395b7
Compare
pablito-perez
force-pushed
the
pablo.perez/data-service-account-exact-match
branch
from
2b42957
to
665d862
Compare
pablito-perez
force-pushed
the
pablo.perez/data-service-account-exact-match-test
branch
from
27395b7
to
ccda8e7
Compare
pablito-perez
force-pushed
the
pablo.perez/data-service-account-exact-match
branch
from
665d862
to
30ab069
Compare
pablito-perez
force-pushed
the
pablo.perez/data-service-account-exact-match-test
branch
from
ccda8e7
to
15271e3
Compare
pablito-perez
force-pushed
the
pablo.perez/data-service-account-exact-match
branch
from
30ab069
to
b046b0c
Compare
|
The issue is fixed "accidentally" in latest versions of the provider, which include this golang change: https://go.dev/blog/loopvar-preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2571
TL;DR: select the correct item when specifying an exact_match filter on the service_account data source
Passes the test added in the previous PR
Longer explanation: when iterating over multiple service account objects returned by the API, the
userDatavariable is assigned to the pointer of the iteratorserviceAccount. The underlying value keeps changing as we iterate over all items. It always ends up pointing to the last item in the collection, even if we did hit an exact match (matchCount == 1).