Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Service Level Objective (SLO) support #263

Merged
merged 16 commits into from
Aug 15, 2019
Merged

Adds Service Level Objective (SLO) support #263

merged 16 commits into from
Aug 15, 2019

Conversation

platinummonkey
Copy link
Contributor

@platinummonkey platinummonkey commented Jul 17, 2019 •
edited
Loading

Adds Service Level Objective support to this provider. These are not to be confused with the SLO widget currently available in dashboards (and soon to be migrated), but the newer centralized SLO management. /api/v1/slo

Note: This required a bump in the zorkian/go-datadog-api client to leverage this change

@ghost ghost added the size/XL label Jul 17, 2019
@platinummonkey platinummonkey mentioned this pull request Jul 18, 2019
Closed
@platinummonkey platinummonkey marked this pull request as ready for review August 8, 2019 19:04
@ghost ghost added size/XL and removed size/XXL labels Aug 9, 2019
nmuesch
nmuesch requested changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@nmuesch nmuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great 🎉 Thanks! Left a few general comments/questions/marks of appreciation 😄

website/docs/r/examples/service_level_objectives.html.markdown Outdated Show resolved Hide resolved
website/docs/r/examples/service_level_objectives.html.markdown Outdated Show resolved Hide resolved
website/docs/r/examples/service_level_objectives.html.markdown Outdated Show resolved Hide resolved
website/docs/r/examples/service_level_objectives.html.markdown Outdated Show resolved Hide resolved
website/docs/r/examples/service_level_objectives.html.markdown Outdated Show resolved Hide resolved
datadog/resource_datadog_service_level_objective.go Show resolved Hide resolved
datadog/resource_datadog_service_level_objective.go Outdated Show resolved Hide resolved
datadog/resource_datadog_service_level_objective.go Outdated Show resolved Hide resolved
datadog/resource_datadog_service_level_objective.go Outdated Show resolved Hide resolved
datadog/resource_datadog_service_level_objective.go Outdated Show resolved Hide resolved
nmuesch
nmuesch requested changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@nmuesch nmuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the iteration! Left one more comment about TypeSet syntax in newer TF versions.

I noticed another issue while running this manually. Looks like there is an unempty diff when applying the same example config twice (on target_display and warning_display

datadog/resource_datadog_service_level_objective_test.go Outdated Show resolved Hide resolved
@gzussa
Copy link
Contributor

gzussa commented Aug 13, 2019

related https://github.com/terraform-providers/terraform-provider-datadog/issues/179

@platinummonkey
fix provider to Optional fields
354e721 
make syntax backwards compatible

suppress *_display changes
nmuesch
nmuesch requested changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@nmuesch nmuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think its pretty much there. Should be the last couple comments. Thanks again for this. 🚀

datadog/resource_datadog_service_level_objective.go Outdated Show resolved Hide resolved
website/docs/r/service_level_objective.html.markdown Outdated Show resolved Hide resolved
website/docs/r/service_level_objective.html.markdown Outdated Show resolved Hide resolved
datadog/resource_datadog_service_level_objective.go Outdated Show resolved Hide resolved
datadog/resource_datadog_service_level_objective.go Outdated Show resolved Hide resolved
nmuesch
nmuesch approved these changes Aug 15, 2019
View reviewed changes
Copy link
Contributor

@nmuesch nmuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me 💯 Thanks again!

@nmuesch nmuesch merged commit dacb378 into DataDog:master Aug 15, 2019
@platinummonkey platinummonkey deleted the slos branch August 15, 2019 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmuesch nmuesch nmuesch approved these changes

Assignees
No one assigned
Labels
dependencies documentation size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@platinummonkey @gzussa @nmuesch