Update dataTables.keyTable.js #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user if focused on an element that isn't the body then button events should be ignored. I had users that had their tab events intercepted instead of tabbing to the next input. If the user has an input, button, etc focused the keys should be ignored.
|
Hi - many thanks for this! I agree with the principle of the issue, but I'm not too sure about the fix. For example, say you had a form just before the table, and wanted to be able to tab into the table - the activeElement would not be the body - it would be the currently focused input element. Thus this approach wouldn't work. I wonder if we should be using ownerDocument on the activeElement instead? If it isn't in the document (or is the document itself), then return out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user is focused on an element that isn't the body then button events should be ignored. I had users that had their tab events intercepted instead of tabbing to the next input. If the user has an input, button, etc focused the keys should be ignored.
I first had it just ignore if the event target was an input, select, etc. Problem with this approach I kept finding more elements that needed to be ignored. Matching on the body element seems to future proof this.