Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opentype #1723

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Opentype #1723

wants to merge 4 commits into from

Conversation

MathanM
Copy link

@MathanM MathanM commented Aug 18, 2024

No description provided.

@DavBfr
Copy link
Owner

DavBfr commented Aug 18, 2024

Nice chunk of work!
How do you plan to use that data?

@MathanM
Copy link
Author

MathanM commented Aug 19, 2024

@DavBfr Currently I am trying follow fontkit which is used by pdfKit and it supports GSUB and GPOS. I am going through their files and got a rough idea how GSUB works, I am planning to implement INDIC Shaper and GSUB, but definitely still there are lot of things that I don't understand. I will try to reach out to fontkit maintainers to see if they can help me on this.
https://github.com/foliojs/fontkit

@MathanM
Copy link
Author

MathanM commented Aug 24, 2024

@DavBfr Question: I saw the ttf_writer.drat, I believe thats the place were glyphInfo is added to the pdf doc, I find it difficult to understand exactly what changes needs to done there! so the question is if I can get you the glyphInfo and code points after gpos and gsub will you be able to continue rest of the work.

To put it in simple terms if I create drat version of fontkit, will you able to integrate ?
https://www.npmjs.com/package/fontkit

@DavBfr
Copy link
Owner

DavBfr commented Aug 26, 2024

I don't really know how font script works.

@@ -116,6 +116,18 @@ class TtfWriter {

glyphsInfo.addAll(glyphsMap.values);

for (int i = 0; i < glyphsInfo.length; i++) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is that for?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not needed.

@DavBfr DavBfr mentioned this pull request Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants