Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix warnings #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix warnings #77

wants to merge 1 commit into from

Conversation

garak
Copy link
Contributor

@garak garak commented Jul 26, 2024

Fix #76

@DavidePastore
Copy link
Owner

Hi @garak. Could you please also include some tests for it?

@garak
Copy link
Contributor Author

garak commented Jul 26, 2024

I just added a test case (and cleaned up tests a bit).
I realized it was my fault in the end, so the case is the same as the other issue I mentioned in mine.
The current test is passing without warnings. If you run the same test on master, you'll get the warnings instead.

The problem, at this point, is that the calculator calculates an invalid cf when passing a shorter belfiore code. The problem is present in master branch too. Let met know if you prefer to merge this PR and wait for a different PR fixing this other problem, or if it's better to fix everything here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uninitialized string offset & Undefined array key
2 participants
@garak @DavidePastore