heroic_util: Remove deprecated type hints #444
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the deprecated type hints
List
andDict
imports fromtyping
and replaces them with standard usage oflist
anddict
that are available since Python 3.9. It also introduces some further type hints to other parts of the util file, although incomplete as typing some parts of this is a little complex given our reliance on parsing JSON (ideally we'll eventually have a JSON type alias, and we will more specifically hint in places where we know the structure of the JSON coming back, like if we know certain objects that we're performing.get
on are always expected to bedict[str, str]
for example). The rationale for further type hinting in the file is to make it easier for unit tests once we eventually get to that stage.