This repository has been archived by the owner on Jan 31, 2019. It is now read-only.
Temp fix for Glimmer 2 Backtracking re-render bug #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardarella
reviewed
Dec 6, 2016
| } = Ember; | ||
|
|
||
| export default EmberObject.extend({ | ||
| unknownProperty(property) { | ||
| set(this, property, emberArray()); | ||
| return get(this, property); | ||
| run.once(() => { set(this, property, emberArray()); }); |
There was a problem hiding this comment.
this feels wrong. Adding a runloop entry shouldn't be necessary
There was a problem hiding this comment.
In that case I'm unsure how to resolve this. At least as a temp solution moving the set into the runloop allows to avoid getting the hard error You modified errors.model twice in a single render from #438 and is also the often-mentioned solution from the original discussion of the Glimmer 2 issue.
Interestingly, the error is only thrown on validation of existing records.
If needed, I can try to reproduce this in a Twiddle.
|
Any update on this? I've had to use the workaround above but agree it feels wrong. |
Fix getOwner polyfill deprecation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #437