chore: 3.12 update #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romgere
reviewed
Oct 11, 2019
romgere
reviewed
Oct 11, 2019
saintsebastian
force-pushed
the
chore/update-3.12
branch
from
5ec7248
to
4b74422
Compare
|
I also removed testing against 2.18, let me know if you disagree with this |
saintsebastian
force-pushed
the
chore/update-3.12
branch
from
4b74422
to
bdc2735
Compare
saintsebastian
force-pushed
the
chore/update-3.12
branch
from
bdc2735
to
82d9005
Compare
|
@romgere thanks for the review, this is now updated |
romgere
approved these changes
Oct 14, 2019
|
LGTM, but I don't understand why this test is still expected : |
|
@romgere i don't know either, i removed the job, but maybe CI cache preserved it? |
|
Yes it is most likely a repo config issue, the 2.18 job is registered as a required check. The repo conf should be updated to look for the whole workflow, but IDK who can do that except @xavier |
|
I've updated the github settings and remove this test from the list of required tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.