Guard DUSD loops with Changi Intermediate 2 #2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Bushstar not needed since its anyway behind the feature flag, and we just don't activate the flag right away. right? so no need for extra fork height. |
|
Since we will be activating it I prefer to put it behind a fork. We tell everyone to update and only activate after the fork has passed. |
agreed, but still: wouldn't need a fork. we can also say "will be activated after block X, everybody needs to update". no difference for users if its an official fork guard or not. just more code |
Bushstar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ChangiIntermediate3 fork and puts the DUSD loop changes behind it.