Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable renaming of tokens on EVM #2821

Merged
merged 8 commits into from
Mar 13, 2024
Merged

Enable renaming of tokens on EVM #2821

merged 8 commits into from
Mar 13, 2024

Conversation

Bushstar
Copy link
Member

@Bushstar Bushstar commented Feb 12, 2024

Summary

  • Supports renaming of tokens EVM side after a hard fork. This PR also puts in some groundwork to enable stock split on EVM by passing the BlockContext to ProcessDeFiEvents for CreateToken and UpdateToken inside of ProcessTokenSplits. For now a dummy context is passed in, but the BlockContext is available.
  • Updates CreateToken and UpdateToken to take a BlockContext reference, CreateToken previously had a BlockContext as a pointer which is less desirable.
  • A previous update prevented tokens from being created with invalid characters in their symbol, however this protection was not included in token updates. This PR prevents using invalid chars when updating a token or loan token symbol.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

sieniven
sieniven previously approved these changes Mar 12, 2024
@Bushstar Bushstar merged commit 895cf23 into master Mar 13, 2024
14 of 16 checks passed
@Bushstar Bushstar deleted the bush/evm-rename-token branch March 13, 2024 09:40
@prasannavl prasannavl mentioned this pull request Mar 22, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants